styles, Card: Fix CSS-only Card with icon
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	lwatson
	Jan 16 2024, 4:45 PM

Description

What's happening?:

The CSS-only version of Card with icon no longer has margin on the card's icon.

Reason: When we increased the specificity [T351753] of cdx-card__icon to cdx-card__icon.cdx-icon, some styles are no longer being applied to the CSS-only version because the card’s icon doesn't have the class cdx-icon.

What should have happened instead?:

Card with icon should have margin applied between the card's icon and text.

Software version
Codex v1.2.1

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update Codex from v1.2.1 to v1.3.0	mediawiki/core	master	+10 K -10 K
	styles, Card: Fix CSS-only Card with icon	design/codex	main	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T351753: Increase specificity when styling subcomponents

Event Timeline

lwatson created this task.Jan 16 2024, 4:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2024, 4:45 PM

lwatson moved this task from Inbox to Up Next on the Design-System-Team board.Jan 16 2024, 7:38 PM

Catrope assigned this task to lwatson.Jan 17 2024, 12:09 AM

Change 991102 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] styles, Card: Fix margin in CSS-only version Card with icon

https://gerrit.wikimedia.org/r/991102

gerritbot added a project: Patch-For-Review.Jan 17 2024, 1:24 AM

lwatson changed the task status from Open to In Progress.Jan 17 2024, 1:25 AM

lwatson moved this task from Up Next to DST-Sprint-14 (2024-01-08 to 2024-01-19) on the Design-System-Team board.

lwatson edited projects, added Design-System-Team (DST-Sprint-14 (2024-01-08 to 2024-01-19)); removed Design-System-Team.

lwatson set the point value for this task to 1.

lwatson moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-14 (2024-01-08 to 2024-01-19)) board.

lwatson renamed this task from styles, Card: Fix margin in CSS-only version Card with icon to styles, Card: Fix CSS-only Card with media .Jan 18 2024, 7:50 PM

Catrope moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-14 (2024-01-08 to 2024-01-19)) board.Jan 19 2024, 10:14 PM

Change 991102 merged by jenkins-bot:

[design/codex@main] styles, Card: Fix CSS-only Card with icon

https://gerrit.wikimedia.org/r/991102

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2024, 10:30 PM

lwatson renamed this task from styles, Card: Fix CSS-only Card with media to styles, Card: Fix CSS-only Card with icon .Jan 19 2024, 11:17 PM

Change 992533 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v1.2.1 to v1.3.0

https://gerrit.wikimedia.org/r/992533

gerritbot added a project: Patch-For-Review.Jan 23 2024, 9:23 PM

Change 992533 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.2.1 to v1.3.0