Page MenuHomePhabricator

CodeReview depends on the removed jquery.tipsy
Closed, ResolvedPublic

Description

ref T117720: Remove use of jquery.tipsy from Wikimedia-maintained code and T143028: Remove use of jquery.tipsy in CodeReview

Breaks CI

21:06:30 There was 1 failure:
21:06:30 
21:06:30 1) ResourcesTest::testValidDependencies
21:06:30 Dependencies that do not exist
21:06:30 Failed asserting that two arrays are equal.
21:06:30 --- Expected
21:06:30 +++ Actual
21:06:30 @@ @@
21:06:30  Array (
21:06:30      'ext.codereview.tooltips' => Array (
21:06:30 +        0 => 'jquery.tipsy'
21:06:30      )
21:06:30      'ext.codereview.overview' => Array (
21:06:30 +        0 => 'jquery.tipsy'
21:06:30      )
21:06:30  )
21:06:30 
21:06:30 /workspace/src/tests/phpunit/structure/ResourcesTest.php:79
21:06:30 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

Event Timeline

Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)

Change 991072 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CodeReview@master] Add local version of jquery.tipsy

https://gerrit.wikimedia.org/r/991072

Change 991072 merged by Reedy:

[mediawiki/extensions/CodeReview@master] Add local version of jquery.tipsy

https://gerrit.wikimedia.org/r/991072

Reedy claimed this task.