Page MenuHomePhabricator

[Regression] Option to change width available at widths where change is impossible
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

With the introduction of the new reading menu, we changed the ui for the width option from the button in the bottom corner of the page to a radio button within the menu.

We did not however port the button's ability to disappear when the width is too narrow for it to take any effect

Acceptance criteria

  • When the width of the page is too narrow for the width radio button to take effect, hide the "width" heading and radio buttons from the menu
  • Note: this should happen at the same width as the previous button at the bottom of the page

Developer notes

We can use the selector vector-client-prefs-vector-feature-limited-width to hide/show this at appropriate resolutions.

QA Results - Beta

ACStatusDetails
1T355331#9503436

QA Results - Prod

ACStatusDetails
1T355331#9540362

Event Timeline

Jdlrobson set the point value for this task to 2.

Change 993816 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Hide limited width client prefs on screen sizes below 1400

https://gerrit.wikimedia.org/r/993816

Change 993816 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide limited width client prefs on screen sizes below 1400

https://gerrit.wikimedia.org/r/993816

Edtadros added subscribers: Jdlrobson, Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: When the width of the page is too narrow for the width radio button to take effect, hide the "width" heading and radio buttons from the menu
@Jdlrobson, can you confirm that the point where the radio buttons should appear/disappear is 1400px? If so this passes.

screenshot 221.mov.gif (846×1 px, 3 MB)

Yep 1400px is the magic number!

Thanks....status updated.

Looks good, resolving

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: When the width of the page is too narrow for the width radio button to take effect, hide the "width" heading and radio buttons from the menu

screenshot 247.mov.gif (1×462 px, 1 MB)

screenshot 246.mov.gif (1×567 px, 2 MB)