PageTriage "PageTriage Toolbar.should allow user to add a maintainence tag to a page" selenium tests is flaky
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Jan 18 2024, 8:33 PM

Description

While CI is running gate-and-submit to merge a patch set for CheckUser (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/990127) it fails with a browser test, but passed the next time.

https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php81-docker/16936/console

20:50:35 [0-1] Error in "PageTriage Toolbar.should allow user to add a maintainence tag to a page"
20:50:48 Error: waitUntil condition timed out after 5000ms
20:50:48     at /workspace/src/extensions/PageTriage/node_modules/webdriverio/build/commands/browser/waitUntil.js:68:19
20:50:48     at async Browser.wrapCommandFn (/workspace/src/extensions/PageTriage/node_modules/@wdio/utils/build/shim.js:137:29)
20:50:48     at async Context.<anonymous> (/workspace/src/extensions/PageTriage/tests/selenium/specs/toolbar.js:67:3)
20:50:48 [0-1] FAILED in chrome - /tests/selenium/specs/toolbar.js (1 retries)

New tests by 431a849f4671ef0edb9b1491948726d6545c8434

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	selenium: Fix flaky test	mediawiki/extensions/PageTriage	master	+5 -5
	Use await more in Selenium tests	mediawiki/extensions/PageTriage	master	+17 -17

Customize query in gerrit

Related Objects

Mentioned In: T333534: Add PageTriage to gated extensions
T355797: Browser Test failures on unrelated patches
Mentioned Here: rEPTR431a849f4671: Add selenium tests for tags module based on current code

Event Timeline

Umherirrender created this task.Jan 18 2024, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2024, 8:33 PM

To find more about the issue there is a mp4 from what the browsers does (for the next 7 days)

Passed:
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php81-docker/16938/artifact/log/PageTriage-Toolbar-should-allow-user-to-add-a-maintainence-tag-to-a-page-2024-01-18T20-17-15-554Z.mp4

Failed:
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php81-docker/16936/artifact/log/PageTriage-Toolbar-should-allow-user-to-add-a-maintainence-tag-to-a-page-2024-01-18T19-50-39-283Z.mp4

It seems the focus is going to the comment field and the submit button is no longer found by the selenium tests or not able to submit due to the focus.

Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Jan 23 2024, 6:24 PM

Novem_Linguae mentioned this in T355797: Browser Test failures on unrelated patches.Jan 24 2024, 3:33 PM

Change 992750 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Use await more in Selenium tests

https://gerrit.wikimedia.org/r/992750

gerritbot added a project: Patch-For-Review.Jan 24 2024, 4:04 PM

dancy subscribed.Jan 25 2024, 4:01 PM

MPGuy2824 moved this task from Priority technical debt to Code Review on the PageTriage board.Jan 30 2024, 6:06 AM

Change 992750 abandoned by Novem Linguae:

[mediawiki/extensions/PageTriage@master] Use await more in Selenium tests

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/994181 solves the issue with less lines changed.