Page MenuHomePhabricator

Gerrit team dashboards no longer load
Closed, ResolvedPublic

Description

Gerrit team dashboards are defined here: https://gerrit.wikimedia.org/r/admin/repos/wikimedia,dashboards

Documentation: https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Gerrit_project_dashboard

This feature no longer works. Most of the dashboards don't load. For example: https://gerrit.wikimedia.org/r/p/wikimedia/+/dashboard/teams:platform

image.png (2×3 px, 191 KB)

Error message is: "Error 400 (Bad Request): Unrecognized value: ignored" "Endpoint: /changes/"

I'm not sure if this happened in the latest Gerrit update or the previous one.

Event Timeline

"ignored" needs to be removed. This was removed in gerrit 3.7.

I guess we just need to remove -is:ignored from the queries here: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/+/refs/meta/dashboards/teams/platform (and in a few other places)

I can do that.

@Paladox Do you know what these queries did previously, before the feature was removed?

I guess we just need to remove -is:ignored from the queries here: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/+/refs/meta/dashboards/teams/platform (and in a few other places)

I can do that.

@Paladox Do you know what these queries did previously, before the feature was removed?

Ignored was a feature that allowed users to ignore changes I think. It's been a while. This was replaced by attention set. That made the feature useless.

That is a fallout of the Gerrit 3.7 upgrade ( T354885 ) as @Paladox said. From https://www.gerritcodereview.com/3.7.html#breaking-changes

The query predicates star:ignored, is:ignored and star:star are not supported anymore. The latter is identical to is:starred or has:star.

Thus the dashboard needs to be amended, something Gerrit does not do for us automatically.

Change 992211 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[wikimedia@refs/meta/dashboards/teams] Remove '-is:ignored' from all dashboards

https://gerrit.wikimedia.org/r/992211

The Language team also discovered this, but they didn't complain ;) https://gerrit.wikimedia.org/r/c/wikimedia/+/992112

Change 992211 merged by Bartosz Dziewoński:

[wikimedia@refs/meta/dashboards/teams] Remove '-is:ignored' from all dashboards

https://gerrit.wikimedia.org/r/992211

matmarex removed a project: Patch-For-Review.

All of the dashboards work for me now.

Well done @matmarex and thank you for having taken care of the updates!