Page MenuHomePhabricator

Gerrit notifications settings default/reset post upgrade
Closed, InvalidPublic

Description

Thank you @hashar for the Gerrit upgrade yesterday! As of today I noticed change activity on IRC and I didn't get the corresponding email which I was expecting. My workflow is to filter generic gerrit emails in their folders, however activity for changes in which I am a reviewer do hit my inbox so they catch my attention.

Case in point is this (EU) morning comments at https://gerrit.wikimedia.org/r/c/operations/puppet/+/990795 which I didn't get an email from gerrit about them:

2024-01-23-093859_2067x1627_scrot.png (1×2 px, 622 KB)

And indeed at https://gerrit.wikimedia.org/r/settings/#Notifications only "submits" is marked for me:

2024-01-23-094001_1467x353_scrot.png (353×1 px, 43 KB)

I am quite sure I didn't change the setting, and seems like a change in defaults post upgrade ?

Event Timeline

I've set my notification preferences as to what they were before (I think?) i.e. all enabled, opening the task for followup/awareness in case it is needed

Indeed that is an issue caused by Gerrit 3.7 which causes emails processing to take a lot more longer than expected (minutes instead of hundred of milliseconds). I think I have found a workaround a couple hours ago :)

As for your notification configuration, that is stored in the All-User repository and when accessing it over ssh you can fetch the config history!

git clone ssh://gerrit.wikimedia.org:29418/All-Users.git
cd All-Users
git config --add remote.origin.fetch +refs/users/self:refs/remotes/origin/users/self
git fetch origin
# From ssh://gerrit.wikimedia.org:29418/All-Users
#  * [new ref]         refs/users/self -> origin/users/self

git checkout -b users/self
# branch 'users/self' set up to track 'origin/users/self'.
# Switched to a new branch 'users/self'
git ls-files
account.config
authorized_keys
preferences.config
watch.config
watch.config
[project "All-Projects"]
	notify = * [ABANDONED_CHANGES, ALL_COMMENTS, NEW_CHANGES, NEW_PATCHSETS, SUBMITTED_CHANGES]

And you can thus look at the log for your watch.config:

git log -n1 watch.config
* 00f0600f00 - (HEAD -> users/29/1629, origin/users/29/1629) Update Project Watches via API (6 hours ago) <Filippo Giunchedi>| 
| diff --git a/watch.config b/watch.config
| index b4079ded4a..39b796c2b1 100644
| --- a/watch.config
| +++ b/watch.config
| @@ -1,2 +1,2 @@
|  [project "All-Projects"]
| -     notify = * [SUBMITTED_CHANGES]
| +     notify = * [ABANDONED_CHANGES, ALL_COMMENTS, NEW_CHANGES, NEW_PATCHSETS, SUBMITTED_CHANGES]

It is magic.

Thank you for the bug report!