Maniphest T355648

ReadingLists: Create a Mocha test suite
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Jan 23 2024, 9:06 AM

Tags

Referenced Files

None

Subscribers

• FJoseph-WMF

Description

In order to ensure compatibility of the new ReadingList REST endpoints with the old ones in RESTbase, we should have a suite of Mocha tests in the extension. The new tests should mirror the assertions made in https://github.com/wikimedia/restbase/blob/master/test/features/lists.js, but the tests need to be re-written to make use of MediaWiki's api-testing framework. This will allow the tests to run reliably and safely in CI and local dev environments.

Details

	Subject	Repo	Branch	Lines +/-
	Mocha Test	mediawiki/extensions/ReadingLists	master	+330 -68
	tests: Mocha tests for ReadingList extension	mediawiki/extensions/ReadingLists	master	+821 -6
	Zuul: [mediawiki/extensions/ReadingLists] Enable Mocha tests	integration/config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T324931 Clean up open RESTBase related tickets
		In Progress		None	T262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
		In Progress		BPirkle	T336693 Re-implement reading lists REST interface outside RESTbase
		Resolved		BPirkle	T348491 Reading List REST Interface: create REST endpoints
		Resolved		BPirkle	T355648 ReadingLists: Create a Mocha test suite

Event Timeline

daniel created this task.Jan 23 2024, 9:06 AM

daniel updated the task description. (Show Details)Jan 23 2024, 9:08 AM

daniel added a subscriber: Atieno.

Change 992667 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/ReadingLists@master] Mocha Test

https://gerrit.wikimedia.org/r/992667

gerritbot added a project: Patch-For-Review.Jan 24 2024, 11:33 AM

Change 992885 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/ReadingLists@master] tests: Mocha tests for ReadingList extension

https://gerrit.wikimedia.org/r/992885

• FJoseph-WMF edited projects, added MW-Interfaces-Team; removed API Platform.Jan 25 2024, 4:33 PM

• FJoseph-WMF moved this task from Incoming (Needs Triage) to In Progress on the MW-Interfaces-Team board.

Change 995062 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[integration/config@master] Enabloe Mocha tests for ReadingLists

https://gerrit.wikimedia.org/r/995062

Change 995062 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/ReadingLists] Enable Mocha tests

https://gerrit.wikimedia.org/r/995062

Mentioned in SAL (#wikimedia-releng) [2024-02-02T21:03:55Z] <James_F> Zuul: [mediawiki/extensions/ReadingLists] Enable Mocha tests for T355648

Change 992885 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] tests: Mocha tests for ReadingList extension

https://gerrit.wikimedia.org/r/992885

Change 992667 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Mocha Test

https://gerrit.wikimedia.org/r/992667

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 12:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 1:01 PM

BPirkle closed this task as Resolved.Feb 22 2024, 4:13 PM