Page MenuHomePhabricator

sre.hardware.upgrade-firmware fails with "unable to extract version"
Closed, ResolvedPublic

Description

ayounsi@cumin1002:~$ sudo cookbook sre.hardware.upgrade-firmware -c nic sretest1003*
Acquired lock for key /spicerack/locks/cookbooks/sre.hardware.upgrade-firmware: {'concurrency': 20, 'created': '2024-01-23 09:01:15.386402', 'owner': 'ayounsi@cumin1002 [3697116]', 'ttl': 1800}
START - Cookbook sre.hardware.upgrade-firmware upgrade firmware for hosts sretest1003.eqiad.wmnet
Acquired lock for key /spicerack/locks/custom/sre.hardware.upgrade-firmware:sretest1003: {'concurrency': 1, 'created': '2024-01-23 09:01:15.447644', 'owner': 'ayounsi@cumin1002 [3697116]', 'ttl': 3600}
Management Password: 
sretest1003.eqiad.wmnet (Gen 15): starting
sretest1003.eqiad.wmnet (NETWORK): update
sretest1003.eqiad.wmnet (NETWORK): current version: 21.85.21.92
poweredge-r450: picking DellDriverCategory.NETWORK update file
We have found multiple entries please pick from the list below:
0: /srv/firmware/poweredge-r450/NETWORK/Network_Firmware_4JJW6_WN64_22.71.3_02.EXE
1: Download new file
==> Please select the entry you want
> 0
User input is: "0"
Released lock for key /spicerack/locks/custom/sre.hardware.upgrade-firmware:sretest1003: {'concurrency': 1, 'created': '2024-01-23 09:01:15.447644', 'owner': 'ayounsi@cumin1002 [3697116]', 'ttl': 3600}
Exception raised while executing cookbook sre.hardware.upgrade-firmware:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/spicerack/_menu.py", line 250, in _run
    raw_ret = runner.run()
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/upgrade-firmware.py", line 968, in run
    failures += self._run_host(hostname)
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/upgrade-firmware.py", line 1016, in _run_host
    if not self.update_driver(
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/upgrade-firmware.py", line 908, in update_driver
    target_version, job_id = self._update(
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/upgrade-firmware.py", line 596, in _update
    target_version, firmware_file = getattr(self, select_firmwarefile)(
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/upgrade-firmware.py", line 557, in _cached_select_firmwarefile
    return self._select_firmwarefile(*args, **kargs)
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/upgrade-firmware.py", line 552, in _select_firmwarefile
    return extract_version(selection), cast(Path, selection)
  File "/srv/deployment/spicerack/cookbooks/sre/hardware/__init__.py", line 48, in extract_version
    raise RuntimeError(f'unable to extract version from: {firmware_file}')
RuntimeError: unable to extract version from: /srv/firmware/poweredge-r450/NETWORK/Network_Firmware_4JJW6_WN64_22.71.3_02.EXE
Released lock for key /spicerack/locks/cookbooks/sre.hardware.upgrade-firmware: {'concurrency': 20, 'created': '2024-01-23 09:01:15.386402', 'owner': 'ayounsi@cumin1002 [3697116]', 'ttl': 1800}
END (FAIL) - Cookbook sre.hardware.upgrade-firmware (exit_code=99) upgrade firmware for hosts sretest1003.eqiad.wmnet

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 992365 had a related patch set uploaded (by Ayounsi; author: Ayounsi):

[operations/cookbooks@master] Firmware extract_version: handle more NIC strings

https://gerrit.wikimedia.org/r/992365

Change 992365 merged by jenkins-bot:

[operations/cookbooks@master] Firmware extract_version: handle more NIC strings

https://gerrit.wikimedia.org/r/992365

ayounsi claimed this task.