Page MenuHomePhabricator
Create Task
Maniphest T355679

PHP Deprecated: Flow\Exception\InvalidTopicUuidException overrides getPageTitle which was deprecated in MediaWiki 1.42. [Called from MWExceptionHandler::report]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Flow\Exception\InvalidTopicUuidException overrides getPageTitle which was deprecated in MediaWiki 1.42. [Called from MWExceptionHandler::report]
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(127)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(378): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(349): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(269): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWException.php(243): MWDebug::detectDeprecatedOverride(Flow\Exception\InvalidTopicUuidException, string, string, string)
#5 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(127): MWException->hasOverriddenHandler()
#6 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(237): MWExceptionHandler::report(Flow\Exception\InvalidTopicUuidException)
#7 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(190): MWExceptionHandler::handleException(Flow\Exception\InvalidTopicUuidException, string)
#8 /srv/mediawiki/php-1.42.0-wmf.15/includes/actions/ActionEntryPoint.php(87): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#9 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(174): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#10 /srv/mediawiki/php-1.42.0-wmf.15/index.php(50): MediaWiki\MediaWikiEntryPoint->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact
Notes

From the same request, three other deprecated messages are emitted:

PHP Deprecated: Flow\Exception\InvalidTopicUuidException overrides getHTML which was deprecated in MediaWiki 1.42. [Called from MWExceptionHandler::report]
from /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(127)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(378): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(349): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(269): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWException.php(241): MWDebug::detectDeprecatedOverride(Flow\Exception\InvalidTopicUuidException, string, string, string)
#5 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(127): MWException->hasOverriddenHandler()
#6 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(237): MWExceptionHandler::report(Flow\Exception\InvalidTopicUuidException)
#7 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(190): MWExceptionHandler::handleException(Flow\Exception\InvalidTopicUuidException, string)
#8 /srv/mediawiki/php-1.42.0-wmf.15/includes/actions/ActionEntryPoint.php(87): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#9 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(174): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#10 /srv/mediawiki/php-1.42.0-wmf.15/index.php(50): MediaWiki\MediaWikiEntryPoint->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
PHP Deprecated: Flow\Exception\FlowException overrides reportHTML which was deprecated in MediaWiki 1.42. [Called from MWExceptionHandler::report]
from /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(127)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(378): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(349): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(269): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWException.php(244): MWDebug::detectDeprecatedOverride(Flow\Exception\InvalidTopicUuidException, string, string, string)
#5 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(127): MWException->hasOverriddenHandler()
#6 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(237): MWExceptionHandler::report(Flow\Exception\InvalidTopicUuidException)
#7 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(190): MWExceptionHandler::handleException(Flow\Exception\InvalidTopicUuidException, string)
#8 /srv/mediawiki/php-1.42.0-wmf.15/includes/actions/ActionEntryPoint.php(87): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#9 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(174): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#10 /srv/mediawiki/php-1.42.0-wmf.15/index.php(50): MediaWiki\MediaWikiEntryPoint->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
PHP Deprecated: Use of MWException::reportHTML was deprecated in MediaWiki 1.42. [Called from Flow\Exception\FlowException::reportHTML]
from /srv/mediawiki/php-1.42.0-wmf.15/extensions/Flow/includes/Exception/FlowException.php(131)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(378): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(349): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.15/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.15/includes/GlobalFunctions.php(774): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWException.php(176): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.42.0-wmf.15/extensions/Flow/includes/Exception/FlowException.php(131): MWException->reportHTML()
#7 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWException.php(225): Flow\Exception\FlowException->reportHTML()
#8 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(131): MWException->report()
#9 /srv/mediawiki/php-1.42.0-wmf.15/includes/exception/MWExceptionHandler.php(237): MWExceptionHandler::report(Flow\Exception\InvalidTopicUuidException)
#10 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(190): MWExceptionHandler::handleException(Flow\Exception\InvalidTopicUuidException, string)
#11 /srv/mediawiki/php-1.42.0-wmf.15/includes/actions/ActionEntryPoint.php(87): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#12 /srv/mediawiki/php-1.42.0-wmf.15/includes/MediaWikiEntryPoint.php(174): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(Flow\Exception\InvalidTopicUuidException)
#13 /srv/mediawiki/php-1.42.0-wmf.15/index.php(50): MediaWiki\MediaWikiEntryPoint->run()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Details

Request URL
https://www.mediawiki.org/wiki/Topic:T4r5k8m7q1sl7jys/
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace subclasses of MWExceptionmediawiki/extensions/Flowmaster+52 -146
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Jan 23 2024, 2:38 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 23 2024, 2:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex subscribed.Jan 23 2024, 2:54 PM

Ugh, the deprecation warning is new from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/983218, and the deprecations in Flow would be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/983257, but the second patch did not get merged.

Options are to revert the first patch, or merge the second patch (or live with the warnings for a while if the volume is not too high).

hashar added a comment.Jan 23 2024, 3:12 PM

(or live with the warnings for a while if the volume is not too high)

I am fine living with the warnings, hence why I haven't made this task a blocker to the train.

Thank you @matmarex!

hashar triaged this task as Medium priority.Jan 23 2024, 3:14 PM
Urbanecm_WMF moved this task from Inbox to Triaged on the Growth-Team board.Jan 23 2024, 3:32 PM
gerritbot added a comment.Jan 23 2024, 4:16 PM

Change 983257 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Flow@master] Replace subclasses of MWException

https://gerrit.wikimedia.org/r/983257

gerritbot added a project: Patch-For-Review.Jan 23 2024, 4:16 PM
matmarex merged a task: T355798: Four deprecation warnings from Flow.Jan 24 2024, 4:15 PM
matmarex added a subscriber: Lucas_Werkmeister_WMDE.
gerritbot added a comment.Jan 24 2024, 4:31 PM

Change 983257 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace subclasses of MWException

https://gerrit.wikimedia.org/r/983257

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 4:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 24 2024, 7:01 PM
Zabe merged a task: T355839: PHP Deprecated: Use of MWException::getHTML was deprecated in MediaWiki 1.42. [Called from Flow\Exception\FlowException::getHTML].Jan 25 2024, 12:53 AM
Zabe subscribed.
matmarex closed this task as Resolved.Jan 25 2024, 3:49 AM
matmarex claimed this task.

Fix will be deployed next week. I was a bit tempted to backport it, but it's already Thursday, and the patch seems just slightly too big and risky to ship right before the weekend.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits