Page MenuHomePhabricator

[L] Reconfigure the placement of release rights info for flickr uploads in upload wizard
Closed, ResolvedPublic

Description

Background

As part of T347705 (which is redesigning how release right questions are asked for multiple uploads) we moved all the release right questions to its own step instead of mixing it with describe step.

However, the behaviour for uploads via Flickr links were not accounted for in the above ticket and as a result release rights related questions/information still remain in "describe" step for the Flickr use case.

The two scenarios that currently exists:

For a license that maps directly to one we support there’s a message on describe indicating the license

Flckr_cc license known.png (236×677 px, 29 KB)

For a “Public Domain Mark” image that doesn’t map directly to a particular license, we also show that message indicating the license on Flickr, but also ask then to select the proper license

Flickr_public domain.png (409×664 px, 50 KB)

Problem

The current presentations of release right questions/information for Flickr links is not consistent with release right questions/info for media uploaded from computer. The release rights related content should not be shown on describe step.

Solution

Flickr upload.png (639×2 px, 129 KB)

Based on the above flow chart the following things in the flow needs to be updated for flickr uploads in order to have a more consistent and simple experience:

  • Update the copy for the warning dialog for flickr uploads when the license is not allowed.
  • Show the license under the Title on upload page for flickr uploads
  • Continue to skip release right step for flickr uploads
  • Remove any mention of release rights or related questions from describe step
  • Auto assign a valid CC license to the upload. For other cases like: If on flickr it says public domain mark, we can assign Public Domain license. (Check Flickypedia as they are following a similar approach)

Event Timeline

Sneha renamed this task from Reconfigure the placement of release rights question/info for flickr uploads in upload wizard to Reconfigure the placement of release rights info for flickr uploads in upload wizard.Feb 21 2024, 1:46 PM
Sneha updated the task description. (Show Details)
Cparle renamed this task from Reconfigure the placement of release rights info for flickr uploads in upload wizard to [L] Reconfigure the placement of release rights info for flickr uploads in upload wizard.Feb 21 2024, 5:41 PM

Change 1010228 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Reimplement external/flickr licensing integration

https://gerrit.wikimedia.org/r/1010228

I have made a couple of changes to the new copy:

  • Instead of explicitly spelling out "Wikimedia Commons", the message will continue to say "this wiki", because UW is also used on other wikis
  • Instead of "photo", the message will continue to say "file", because other formats (e.g. video) are also possible

The message will be:

This file on Flickr is under the following license: All Rights Reserved.

Unfortunately, this wiki does not accept that license.


FYI: In addition to single files, it's also possible to upload a whole flickr photoset at once. If it contains no messages, then this message is displayed:

Unfortunately, no image in the photoset has a license appropriate to be used on this site.

I have left that message unchanged, but have changed the title from "There was an error in your submission" to "These files can't be used"

Thanks @matthiasmullie all the changes makes sense. For the first message I believe you also changed the title of the prompt to "This file can't be used"

Change 1010228 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Reimplement external/flickr licensing integration

https://gerrit.wikimedia.org/r/1010228

@matthiasmullie - on commons beta when attempting to upload flickr images, I immediately got :

Refused to connect to 'https://api.flickr.com/services/rest/?&api_key=e9d8174…&format=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo' because it violates the following Content Security Policy directive: "default-src 'self' data: blob: https://upload.wikimedia.beta.wmflabs.org meta.wikimedia.beta.wmflabs.org *.wikimedia.beta.wmflabs.org [...] Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

The same flickr link to my image worked in production commons wmf.23 (this link).
I tried to disable security.csp.enable in my Firefox - no success. Any ideas how to override headers or, better, to make 'connect-src' to match the production setup?

commons wmf.23 displays:

Referrer Policy: Ignoring the less restricted referrer policy “origin-when-cross-origin” for the cross-site request: https://api.flickr.com/services/rest/?&api_key=e9d8174a79c782745289969a45d350e8&format=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo

@Etonkovidova I think that's a beta-specific issue (T249486, I think). This just got deployed in prod, where uploads from Flickr seem to work AFAICT!

@Sneha - moving to Design QA only FYI. The scope of this task is done & verified in commons wmf.24, so if no follow-up actions are needed for this specific task, you may close it as Resolved.

The current Flickr files upload issues:
(1) There are two types of limitations for images on Flickr that affect Special:UploadWizard workflows: Licensing and Viewing privacy (can be Private or Public; Friends/Family access falls into Private). As such, an image may be Public and having All rights reserved or vice versa. Special:UploadWizard currently handles those cases with different warnings:

not Public domain license + viewing status PublicThe warning is according to the task specs:
Screen Shot 2024-03-27 at 12.16.15 PM.png (1×1 px, 215 KB)
Public domain license + viewing status NOT PublicThe warning is a general warning for any type of error in an URL
Screen Shot 2024-03-27 at 12.13.34 PM.png (1×1 px, 185 KB)

(2) Uploads with mixed (Flickr and other files) silently fail to display flickr images. I suspect that the issue has been present for a long time. The gif below shows

  • three uploaded files - a file from flickr and two files from a hard drive
  • going to the next step - Release rights, the flickr image fails to be displayed.

mixed_uploads2.gif (891×1 px, 985 KB)

@Etonkovidova I think that's a beta-specific issue (T249486, I think). This just got deployed in prod, where uploads from Flickr seem to work AFAICT!

Thx, @matthiasmullie - it's good to know that a bug was filed already. Yes, I've checked Flickr upload in production.

(2) Uploads with mixed (Flickr and other files) silently fail to display flickr images. I suspect that the issue has been present for a long time. The gif below shows

  • three uploaded files - a file from flickr and two files from a hard drive
  • going to the next step - Release rights, the flickr image fails to be displayed.

mixed_uploads2.gif (891×1 px, 985 KB)

Flickr uploads bypass release rights, because they are automatically mapped to the equivalent on-wiki license.
Per the flowchart in the description, only local uploads should be shown in release rights, and Flickr uploads not shown.

(2) Uploads with mixed (Flickr and other files) silently fail to display flickr images. I suspect that the issue has been present for a long time. The gif below shows

  • three uploaded files - a file from flickr and two files from a hard drive
  • going to the next step - Release rights, the flickr image fails to be displayed.

mixed_uploads2.gif (891×1 px, 985 KB)

Flickr uploads bypass release rights, because they are automatically mapped to the equivalent on-wiki license.
Per the flowchart in the description, only local uploads should be shown in release rights, and Flickr uploads not shown.

Probably, I misread the flow chart, thx, @matthiasmullie. Still, handling mixed upload might need some improvement, but it's out of the scope of the present work.

@Etonkovidova I checked the flow and it looks good to me. For the two things you pointed out above 1) URL warning for not public photos was missed from this ticket but it is good to know that message exists. Perhaps needs another ticket to improve messaging. 2) flickr images not showing in release right step is intentional because users do not need to provide release right info for flickr uploads.