Maniphest T355765

🍦 Validate sitelink title in SetItemSitelink
Closed, ResolvedPublic
Actions

Assigned To

Dima_Koushha_WMDE

Authored By

	Ollie.Shotton_WMDE
	Jan 24 2024, 11:50 AM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

Validate
- Sitelink title field not provided (sitelink-data-missing-title)
- Title is empty (title-field-empty)
- Invalid title (invalid-title-field)
Skip title existence check (title-does-not-exist)

Details

Other Assignee: Ollie.Shotton_WMDE

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Validate PUT sitelink title	mediawiki/extensions/Wikibase	master	+353 -24

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ifrahkhanyaree_WMDE	T344228 Functionality for REST API v1
		Resolved		Ifrahkhanyaree_WMDE	T342987 🍦 Create/replace a sitelink to an item on a given wiki
		Resolved		Dima_Koushha_WMDE	T355765 🍦 Validate sitelink title in SetItemSitelink

Event Timeline

Ollie.Shotton_WMDE created this task.Jan 24 2024, 11:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2024, 11:50 AM

Ollie.Shotton_WMDE updated the task description. (Show Details)Jan 24 2024, 11:52 AM

Dima_Koushha_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 12) board.Feb 2 2024, 1:49 PM

Change 997552 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Validate PUT sitelink title

https://gerrit.wikimedia.org/r/997552

gerritbot added a project: Patch-For-Review.Feb 5 2024, 8:05 PM

WMDE-leszek edited projects, added Wikibase Reuse Team (Sprint 13); removed Wikibase Reuse Team (Sprint 12).Feb 6 2024, 10:49 AM

WMDE-leszek moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 13) board.

Ollie.Shotton_WMDE assigned this task to Dima_Koushha_WMDE.Feb 7 2024, 10:11 AM

Ollie.Shotton_WMDE updated Other Assignee, added: Ollie.Shotton_WMDE.

Dima_Koushha_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 13) board.Feb 9 2024, 9:52 AM

Change 997552 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate PUT sitelink title

https://gerrit.wikimedia.org/r/997552

Dima_Koushha_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 13) board.Feb 14 2024, 3:15 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 3:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 14 2024, 6:00 PM

Ifrahkhanyaree_WMDE closed this task as Resolved.Feb 20 2024, 1:33 PM