Longer term, we should do away with shell scripts (T348479) to facilitate readability and testing.
In the meantime, having shellcheck for linting and helping avoid mistakes is a good idea, and using shfmt to provide consistent formatting across individuals on the team is also useful.
kharlan updated https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/217
gitlab-ci: Add shellcheck to test stage
kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/218
gitlab-ci: Add shfmt to test stage
stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/217
gitlab-ci: Add shellcheck to test stage
stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/218
gitlab-ci: Add shfmt to test stage