Description
Details
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Use foreign resources for updating Ace | TheDJ | mediawiki/extensions/CodeEditor | master | +9 -198 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T275660 Proliferate foreign-resources.yaml in mediawiki extensions and skins | |||
| Open | None | T330430 Proliferate usage of foreign-resources.yaml in WMF deployed and MW bundled skins and extensions | |||
| Resolved | TheDJ | T355823 Add a foreign-resources.yaml file to CodeEditor | |||
| Declined | BUG REPORT | None | T387250 ManageForeignResources fails to install Ace 1.37.1 when local disk is case-insenstive |
Event Timeline
It does have one now, but it still needs the declaration of which files it should copy.
Change #1108849 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/CodeEditor@master] [WIP] Use foreign resources for updating
Ran into a small issue.. It seems that the tar file that ace9 publishes, is doing something that is confusing php's extract.
Error: Extraction from phar "/Users/hartman/Development/wikimedia-git/mediawiki-extensions/CodeEditor/modules/lib/.foreign/tmp/ace.tar" failed: Cannot extract "ace-builds-1.37.1/demo/kitchen-sink/docs/haxe.hx" to "/Users/hartman/Development/wikimedia-git/mediawiki-core/extensions/CodeEditor/modules/lib/.foreign/tmp/ace/ace-builds-1.37.1/demo/kitchen-sink/docs/haxe.hx", path already exists
I'm assuming this is something in the index of the tar file, that makes it want to write the file twice or something. I was able to make it pass by setting overwrite to true in ForeignResourceManager.php. Will have to double check if that makes sense.
$p->extractTo( $tmpDir, null, true );
I'm assuming this is something in the index of the tar file, that makes it want to write the file twice or something
This was fixed upstream in ace 1.39.1
Change #1108849 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] Use foreign resources for updating Ace