Page MenuHomePhabricator

Login page button/s limit/s longer button texts (solution included)
Closed, ResolvedPublicBUG REPORT

Description

  • Observed in REL1_41. (Perhaps a regression, I am not sure)

Problem:

When changing the login button text

Mediawiki core: css id: #wpLoginAttempt ; System text MediaWiki:Pt-login-button
Extension:PluggableAuth: css id: w-input-pluggableauthlogin0

I observed, that longer texts are cut, because the button size limits the text, the button size is not enlarged correspondingly.

These buttons should be skinned in the MW-Core with:

white-space: normal; 
word-wrap: break-word; 
height: auto;

Remark / workaround:

I documented a workaround (until the MediaWiki Core skin is corrected) which can be applied in LocalSettings.php here:

https://www.mediawiki.org/w/index.php?title=Topic:Xx8ol75kyh1qejp8&topic_showPostId=xxwgghjgcqfymj9x#flow-post-xxwgghjgcqfymj9x

and here:

https://www.mediawiki.org/wiki/Topic:Xxwh5hbjqn2834dw

Event Timeline

Wikinaut renamed this task from [Mediawiki Core] Login page button/s limit/s longer button texts (solution included) to Login page button/s limit/s longer button texts (solution included).Jan 25 2024, 8:18 AM

Change #1191778 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Make the login and signup forms wider

https://gerrit.wikimedia.org/r/1191778

Change #1191778 merged by jenkins-bot:

[mediawiki/core@master] Make the login and signup forms wider

https://gerrit.wikimedia.org/r/1191778

matmarex claimed this task.
matmarex subscribed.

My change makes the forms wider, which should reduce the severity of the problem.

It's still possible to exceed the available length. It seems that it was decided not to allow line wrapping for buttons (T359636), and instead limit text length with an ellipsis (T337865), but that was never implemented. I think there is nothing to do in this task though, the buttons are the same as anywhere else in MediaWiki.

Change #1199266 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_44] Make the login and signup forms wider

https://gerrit.wikimedia.org/r/1199266

Change #1199267 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_43] Make the login and signup forms wider

https://gerrit.wikimedia.org/r/1199267

Change #1199267 merged by jenkins-bot:

[mediawiki/core@REL1_43] Make the login and signup forms wider

https://gerrit.wikimedia.org/r/1199267

Change #1199266 merged by jenkins-bot:

[mediawiki/core@REL1_44] Make the login and signup forms wider

https://gerrit.wikimedia.org/r/1199266