Page MenuHomePhabricator
Create Task
Maniphest T355865

Help popup button attached to FieldsetLayout has incorrect click target
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Esanders
Jan 25 2024, 11:43 AM
Tags
Referenced Files
F41716440: image.png
Jan 25 2024, 12:32 PM
F41716452: image.png
Jan 25 2024, 12:32 PM
F41716444: image.png
Jan 25 2024, 12:32 PM
F41716454: image.png
Jan 25 2024, 12:32 PM
F41716344: image.png
Jan 25 2024, 11:43 AM
F41716341: image.png
Jan 25 2024, 11:43 AM
F41716339: image.png
Jan 25 2024, 11:43 AM
Subscribers
Aklapper
Esanders

Description

The help button attached to a FieldLayout is positioned correctly and has even padding when focused:

image.png (81×408 px, 5 KB)

The same is not true of FieldsetLayouts:

image.png (105×435 px, 10 KB)

This can be seen in various places in the wild, such as the VE media dialog:

image.png (293×517 px, 23 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.49.0mediawiki/coremaster+1 K -1 K
FieldsetLayout: Fix position and padding of help buttonoojs/uimaster+14 -12
Customize query in gerrit

Event Timeline

Esanders created this task.Jan 25 2024, 11:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2024, 11:43 AM
gerritbot added a comment.Jan 25 2024, 12:31 PM

Change 992921 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] FieldsetLayout: Fix position and padding of help button

https://gerrit.wikimedia.org/r/992921

gerritbot added a project: Patch-For-Review.Jan 25 2024, 12:31 PM
Esanders added a comment.Jan 25 2024, 12:32 PM

Before

image.png (250×585 px, 24 KB)
image.png (253×578 px, 27 KB)

After

WMUIApex
image.png (250×585 px, 24 KB)
image.png (253×578 px, 24 KB)
Jdforrester-WMF updated the task description. (Show Details)Jan 25 2024, 3:15 PM
gerritbot added a comment.Jan 25 2024, 3:18 PM

Change 992921 merged by jenkins-bot:

[oojs/ui@master] FieldsetLayout: Fix position and padding of help button

https://gerrit.wikimedia.org/r/992921

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2024, 3:30 PM
gerritbot added a comment.Feb 7 2024, 7:41 PM

Change 998536 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.49.0

https://gerrit.wikimedia.org/r/998536

gerritbot added a project: Patch-For-Review.Feb 7 2024, 7:41 PM
gerritbot added a comment.Feb 8 2024, 3:09 PM

Change 998536 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.49.0

https://gerrit.wikimedia.org/r/998536

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 3:30 PM
DLynch assigned this task to Esanders.Feb 8 2024, 4:15 PM
DLynch moved this task from To Triage to Triaged on the VisualEditor board.
DLynch added a project: Editing QA.
DLynch added a project: Editing-team (Kanban Board).
DLynch moved this task from Inbox to QA on the Editing-team (Kanban Board) board.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 8 2024, 5:00 PM
EAkinloose edited projects, added Verified; removed Editing QA.Feb 21 2024, 11:25 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders closed this task as Resolved.Feb 22 2024, 6:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits