Page MenuHomePhabricator

Surface not focused after closing a dialog
Closed, ResolvedPublic

Description

  1. Open a dialog, e.g. the media dialog
  2. Make a change and apply, or press the close button
  3. Observed: the surface is not focussed, leaving a greyed out selection, and no way to move the cursor with a keyboard
    image.png (271×434 px, 68 KB)
  1. Expected: the surface is focussed, the selection is blue, and the selection can be moved with the keyboard
    image.png (271×434 px, 62 KB)

Event Timeline

Change 992933 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] WindowAction: Wait for 'closed' promise before re-activating

https://gerrit.wikimedia.org/r/992933

Technically a dupe of T337187 I think, but since this has a patch on it I'll just merge the earlier one in.

DLynch moved this task from Inbox to QA on the Editing-team (Kanban Board) board.
DLynch added a project: Editing QA.

Change 992933 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] WindowAction: Wait for 'closed' promise before re-activating

https://gerrit.wikimedia.org/r/992933

Change 993811 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e6f20f81)

https://gerrit.wikimedia.org/r/993811

Change 993811 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e6f20f81)

https://gerrit.wikimedia.org/r/993811

This works for images, but not Gallery.

Screenshot 2024-02-01 at 15.34.15.png (392×1 px, 34 KB)

Would the expected behaviour be that the gallery is focused if a change is applied to any of the images?
Also what is the expected behaviour if changes are applied to the gallery? Changing the caption for instance.

For consistency, I'd say we have the gallery focused as seen in the screenshot.

Experience:

Screenshot 2024-02-01 at 15.37.05.png (618×1 px, 58 KB)

Expected?:

Screenshot 2024-02-01 at 15.37.14.png (534×1 px, 47 KB)

Note: I am able to navigate with the arrow keys on the keyboard after interacting with the gallery so, I wouldn't say accessibility is broken.