Page MenuHomePhabricator

Rename WDQS whitelist to allowlist
Closed, ResolvedPublicBUG REPORT

Description

The wikidata query service defines a whitelist to search for allowed SPARQL hosts. We use WDQS to manage mathematical research data. In this context, the term whitelist is discouraged. An alternative is allowlist.

Event Timeline

Physikerwelt added a subscriber: Daniel_Mietchen.

I stumbled over this when looking into a problem reported by @Daniel_Mietchen, who realized that the values in the allow-list do not seem to work https://github.com/MaRDI4NFDI/portal-compose/issues/473. So maybe this is also the cause of a functional problem.

However, on the box we use I see the following

bash-4.4# cat runBlazegraph.sh | grep allow
ALLOWLIST=${ALLOWLIST:-"allowlist.txt"}

We've been getting reports of Wikibase community WDQS end-users having trouble using whitelist.txt - might the changes in T343856 have broken use of this file if they had it incorporated into a Wikibase docker/suite setup? It looks like wmde.16 version of wikibase-release-pipeline is still using whitelist.txt.

Example from the Wikibase Community telegram chat:
"this should work, but you’ll need to allow WDQS in your query service’s allowlist first [...] no, it’s usually a file whitelist.txt in your WDQS installation"
"weird. I'm on a default installation of wikibase from docker, and that default installation contains the wikidata query service in its whitelist.txt So why is it not allowed...? hmm..."

(I think the plan for MediaWiki: spam message changes had allow/deny variants as additions to existing white/black rather than replacing them, at least for a transition period. It seems there is backwards-compatibility code in T344284 that anticipates this, but maybe it is not working as intended?)

RickiJay-WMDE changed the task status from Open to In Progress.Mar 27 2024, 4:28 PM
RickiJay-WMDE claimed this task.