Hi @scblr

Still wip, as I need your input on this. Can be tested here:
https://github.com/wikimedia/apps-android-wikipedia/pull/4465/checks

However, during testing I am finding that as with all other places, there is a time lag in change propagation. So even when the user uses the edit cta and updates the article content, they might not come back to see the change they made.
You can test this by creating linking pages on test wiki like this one: https://test.wikipedia.org/wiki/AndroidAppTestPage2

@Sharvaniharan APK is expired 👇

Thanks for updating.

Hi @scblr

Could you please check this again: https://github.com/wikimedia/apps-android-wikipedia/pull/4465/checks. I was able to download.. but if you have problems again, I will create a separate branch.
Thank you.

Thanks @Sharvaniharan

1) It seems like the "Edit article" button does not use the specs on Figma (especially the height)? It uses the measurements as other buttons that have been defined in T331450.

Design	vs	Implementation

2) Re: your Slack message

Since it takes a while for that edit to get processed[sometimes a day], we cannot immediately update the content when the user comes back to AndroidAppTestPage2 after adding content to AndroidAppTestPage3.. so what do we do in such cases? What message to show the user?

• Adapt the copy to the first part only: This article is a stub, which means there isn’t enough content in the article to generate a preview.
• And hide the "Edit article" button

3) Minor: the current implementation lacks a full stop:

Hi @scblr
Have fixed 1) annd 3), but have a question about 2) about how you are envisioning the edit message change:
a: It would be hard to have a link-specific message like how you are suggesting, because we will have to remember that for all links that get accessed in that session, which is cumbersome.
b: If you want the dialog to stay active when we go to edit mode, we can update when we come back, but if the user dismisses the dialog and then visits it again, they will see the original stub placeholder text and not the shorter one.
c: Best possible solution can be to update the toast message to indicate that they wont see a change in preview for that link immediately. So instead of Edit published! which is displayed now, we can have Edit published! It might take some time before you see your contribution in the preview - something like that?

Hi @Sharvaniharan, I think your suggestion in c) sounds good.

I have a shorter copy suggestion, though:

Edit published! Changes may take time to appear.

Hi @scblr

I fixed the toast message and made a short screen rec in case you did not easily find a stub article to edit. Feel free to use the same to test it out.: https://youtu.be/zapBN4O915M
[Took a while to publish the edit to the testwiki article but I don't think this is a typical delay for real wikis]

@Sharvaniharan, thanks for the video! I was wondering about the last scene in the video:

Can we keep the bottom sheet active when users have published the edit? Basically go back to this view after publishing the edit:

With the snackbar above the sheet?

If this is not feasible – I suggest the following copy change:

Edit to %articleName published! Changes may take time to appear.

Thanks!

Hi @scblr

Thank you. makes sense. Put in the change:

@Sharvaniharan – any chance to move the snackbar up, as we have it in the "Add images" Suggested edit? (T336502#9082815) 👇

Thanks!

Hi @scblr
Updated this:

It's not ideal as it’s overlapping UI elements (Edit article), but better @Sharvaniharan, so let’s move this to code review 👍. Thanks for the work on this!

Testing on 2.7.50480-beta-2024-03-27 on test.wiki

Using this article: https://test.wikipedia.org/wiki/AndroidAppTestPage2

I am seeing this when viewing the link preview:

@ABorbaWMF Appearing correctly for me:

@Dbrant—Yes, it is working now, which is odd. When I looked last week, it was not showing the stub text. I tried a bunch of times and even tried adding coordinates to a stub article on test to hopefully see the preview in places. So yeah, maybe it was a network thing.

Working for me on 2.7.50481-beta-2024-04-01