[Unplanned] Regression: Minerva tabs on certain special pages are appearing unstyled on non English Wikipedias
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 29 2024, 10:04 PM

Description

Steps to replicate the issue (include links if applicable):

Go https://es.m.wikipedia.org/w/index.php?title=Regi%C3%B3n_de_Valpara%C3%ADso&action=history
Also occurs on https://es.m.wikipedia.org/wiki/Especial:MobileDiff/157336990
Also occurs on https://meta.m.wikimedia.org/wiki/Special:CentralNotice

What happens?:

Screenshot 2024-01-29 at 2.04.02 PM.png (738×463 px, 83 KB)

What should have happened instead?:

Screenshot 2024-01-29 at 2.04.39 PM.png (694×450 px, 70 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Seems to be resolved with the following code:

mw.loader.using('skins.minerva.amc.styles')

Works fine on
https://en.m.wikipedia.org/wiki/Special:MobileDiff/157336990

QA Results - Beta

AC	Status	Details
1	✅	T356117#9503517

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix styling of tabs on history and diff pages	mediawiki/skins/MinervaNeue	master	+19 -3

Customize query in gerrit

Related Objects

Mentioned In: T355380: Verify 1.42.0-wmf.16 deployment
T312813: [Regression(??)] Styling issue on non-AMC history and diff pages

Event Timeline

Jdlrobson created this task.Jan 29 2024, 10:04 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJan 29 2024, 10:04 PM

Jdlrobson updated the task description. (Show Details)Jan 29 2024, 10:05 PM

Jdlrobson renamed this task from Minerva tabs on certain pages are appearing unstyled on French/Spanish Wikipedia (maybe other projects to Minerva tabs on diff and history page are appearing unstyled on French/Spanish Wikipedia (maybe other projects.Jan 29 2024, 10:13 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Minerva tabs on diff and history page are appearing unstyled on French/Spanish Wikipedia (maybe other projects to Minerva tabs on certain special pages are appearing unstyled on French/Spanish Wikipedia (maybe other projects.Jan 29 2024, 10:18 PM

Jdlrobson updated the task description. (Show Details)

Change 993808 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix styling of tabs on history and diff pages

https://gerrit.wikimedia.org/r/993808

gerritbot added a project: Patch-For-Review.Jan 29 2024, 10:19 PM

Jdlrobson renamed this task from Minerva tabs on certain special pages are appearing unstyled on French/Spanish Wikipedia (maybe other projects to Regression: Minerva tabs on certain special pages are appearing unstyled on French/Spanish Wikipedia (maybe other projects.Jan 29 2024, 11:36 PM

Jdlrobson renamed this task from Regression: Minerva tabs on certain special pages are appearing unstyled on French/Spanish Wikipedia (maybe other projects to Regression: Minerva tabs on certain special pages are appearing unstyled on non English Wikipedias.

Jdlrobson renamed this task from Regression: Minerva tabs on certain special pages are appearing unstyled on non English Wikipedias to [Unplanned] Regression: Minerva tabs on certain special pages are appearing unstyled on non English Wikipedias.

Jdlrobson triaged this task as High priority.

Jdlrobson edited projects, added Regression; removed Web-Team-Backlog-Archived (Needs Prioritization (Tech)).

Jdlrobson added a project: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2).

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2) board.

Change 993808 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix styling of tabs on history and diff pages

https://gerrit.wikimedia.org/r/993808

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 30 2024, 1:00 AM

Jdlrobson assigned this task to Edtadros.Jan 30 2024, 1:06 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2024, 1:30 AM

Jdlrobson mentioned this in T312813: [Regression(??)] Styling issue on non-AMC history and diff pages.Jan 30 2024, 9:13 PM

Test Result - Beta

Status: ✅ PASS
Environment: esbeta, metabeta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Minerva tabs should be styled on special and non-english pages

History Page

Mobile Diff

Central Notice

Edtadros updated the task description. (Show Details)Jan 31 2024, 6:56 PM

Jdlrobson assigned this task to ovasileva.Feb 1 2024, 5:34 PM

ovasileva closed this task as Resolved.Feb 5 2024, 5:16 PM

Test Result - Prod

Status: ✅ PASS
Environment: eswiki, metawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Minerva tabs should be styled on special and non-english pages

History Page

Mobile Diff

Central Notice

Edtadros mentioned this in T355380: Verify 1.42.0-wmf.16 deployment.Feb 5 2024, 5:52 PM

	F41729527: Screenshot 2024-01-29 at 2.04.39 PM.png
	Jan 29 2024, 10:04 PM

	F41729523: Screenshot 2024-01-29 at 2.04.02 PM.png
	Jan 29 2024, 10:04 PM

	F41784040: screenshot 428.png
	Feb 5 2024, 5:36 PM

	F41784035: screenshot 427.png
	Feb 5 2024, 5:36 PM

	F41784033: screenshot 426.png
	Feb 5 2024, 5:36 PM

	F41735536: screenshot 418.png
	Jan 31 2024, 6:54 PM

[Unplanned] Regression: Minerva tabs on certain special pages are appearing unstyled on non English WikipediasClosed, ResolvedPublicBUG REPORTActions

Description

QA Results - Beta

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

[Unplanned] Regression: Minerva tabs on certain special pages are appearing unstyled on non English Wikipedias
Closed, ResolvedPublicBUG REPORT
Actions