Page MenuHomePhabricator

Adjust Lexeme Special Pages to not leak IPs when editing and IP masking is enabled
Closed, ResolvedPublic

Description

Problem:
We are currently leaking the IPs of users who are not logged in when making edits on Lexeme Special Pages.

With temporary accounts are enabled on the repo, we must not leak the IPs of users who are not logged in and add entry with their temporary account name instead to the edit histories etc.

Affected Lexeme SpecialPages

BDD
GIVEN a user who isn't logged in
AND Temporary Accounts are enabled
WHEN an edit is made on a Lexeme Special Page
THEN an entry with their temporary account name is added to the edit history of the Item

Acceptance criteria:

  • IP is not leaked for users editing on the Create LexemeSpecialPage and IP masking is enabled on the repo
  • IP is not leaked for users editing on the Merge Lexeme SpecialPage and IP masking is enabled on the repo

Event Timeline

Arian_Bozorg claimed this task.

Reopening for the MergeLexeme part, change coming up in a moment.

Change 1003800 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Correctly thread temp users on lexeme merge

https://gerrit.wikimedia.org/r/1003800

Change 1005120 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Remove LexemeRedirector, directly use MediaWikiLexemeRedirector

https://gerrit.wikimedia.org/r/1005120

Change 1003800 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Correctly support temp users when merging lexemes

https://gerrit.wikimedia.org/r/1003800

Change 1005120 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Remove LexemeRedirector, directly use MediaWikiLexemeRedirector

https://gerrit.wikimedia.org/r/1005120

Arian_Bozorg claimed this task.

Looks good to me! Thanks so much