Page MenuHomePhabricator
Create Task
Maniphest T356292

Return global contributions by temporary accounts given an IP address or range
Closed, ResolvedPublic
Actions

Description

Background

For full details see T337089: [Epic] Implement global contributions feature.

Technical background

Since T363358: Create extendable parent classes for special pages showing contributions lists, MediaWiki core has parent classes for building pages that display lists of contributions: ContributionsSpecialPage and ContributionsPager. These are currently used to make Special:Contributions, Special:DeletedContributions and (in CheckUser) Special:IPContributions.

For Special:GlobalContributions, we will need SpecialGlobalContributions and GlobalContributionsPager. This will work similarly to Special:IPContributions in normal (non-archive) mode. Since it needs to use the CheckUser tables, it will only show contributions from the last 90 days.

This task is for creating the pager (which fetches the results and displays them).

Acceptance criteria
  • GlobalContributionsPager is implemented, extending ContributionsPager
  • GlobalContributionsPager::doQuery logs access, similar to`IPContributionsPager`
  • GlobalContributionsPager::getRevisionQuery is overridden to fetch the latest contributions by temporary accounts from a given IP or range. It makes use of the cuci_temp_edit table and possibly other optimizations discussed in T355672: Investigate: How to make the GUC query performant. This is the bulk of the work for this task.
  • Submitting the form with an IP address or range fetches the latest revisions from temporary accounts using those IP addresses for all wikis in this wiki farm (limit to 20 per wiki)
  • Results are displayed in a paginated list and sorted by descending timestamp
  • Visibility of contributions (hidden users, suppression, etc) works the same as for the other contributions special pages
  • IP reveal is not available on this page (since IP look-ups that are not local would fail)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add source wiki to contributions on Special:GlobalContributionsmediawiki/extensions/CheckUserwmf/1.43.0-wmf.28+48 -0
Support template overrides in ContributionsPagermediawiki/corewmf/1.43.0-wmf.28+72 -49
Update GlobalContributionsPager to format external revision rowsmediawiki/extensions/CheckUsermaster+545 -1
Add source wiki to contributions on Special:GlobalContributionsmediawiki/extensions/CheckUsermaster+48 -0
Support template overrides in ContributionsPagermediawiki/coremaster+72 -49
ContributionsPager: Add docs about external comments displaymediawiki/coremaster+2 -0
ContributionsPager: Show user links for external revisionsmediawiki/coremaster+55 -14
ContributionsPager: Add comment about external tags displaymediawiki/coremaster+3 -0
ContributionsPager: Show annotations for current external revisionsmediawiki/coremaster+15 -16
ContributionsPager: Show flags for external revisionsmediawiki/coremaster+5 -8
ContributionsPager: Support article link for external revision rowsmediawiki/coremaster+25 -10
Add ContributionsPager->isFromExternalWiki() helper functionmediawiki/coremaster+11 -0
Support external revisions in ContributionsPager->formatVisibilityLink()mediawiki/coremaster+39 -11
Support diff/history, date, and source wiki for Special:GC external revsmediawiki/coremaster+112 -27
ContributionsPager: Make formatRow safe for for external revisionsmediawiki/coremaster+66 -17
ContributionsPager: Split formatRow into separate methodsmediawiki/coremaster+322 -206
IPContributions/GlobalContributions: Make use of the query builder construction utilitymediawiki/extensions/CheckUsermaster+3 -6
GlobalContributionsPager: Use a join instead of two queriesmediawiki/extensions/CheckUsermaster+8 -17
Query contributions globally on Special:GlobalContributionsmediawiki/extensions/CheckUsermaster+144 -0
Update ContributionsPager to support Special:GlobalContributionsmediawiki/coremaster+31 -2
Remove IP reveal from Special:GlobalContributionsmediawiki/extensions/CheckUsermaster+1 -0
Initialise Special:GlobalContributions only if CentralAuth is loadedmediawiki/extensions/CheckUsermaster+19 -16
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT384604 [Epic] Use Codex on Special:GlobalContributions
 OpenNoneT358048 Use Codex HtmlForm in Special:GlobalContributions
 OpenNoneT358047 Add ToggleButtonGroup to Special:GlobalContributions for displaying results in a table
 OpenNoneT371917 Use a time period field in Special:GlobalContributions instead of start/end date fields
 ResolvedSTranT356292 Return global contributions by temporary accounts given an IP address or range
 ResolvedTchandersT355672 Investigate: How to make the GUC query performant
 ResolvedSTranT356289 Create a special page for viewing global user contributions
 ResolvedDreamy_JazzT373018 [Epic] Write to, populate, and purge data from the CheckUser central index tables
 ResolvedDreamy_JazzT371789 Create a maintenance script for populating the cuci_temp_edit and cuci_user tables
 ResolvedDreamy_JazzT371788 Update cuci_temp_edit table each time a temp user edits
 ResolvedDreamy_JazzT373021 Write to cuci_user table when CheckUser actions occur
 ResolvedDreamy_JazzT372865 Purge expired data from the cuci_temp_edit and cuci_user tables
 ResolvedDreamy_JazzT359560 Create the CheckUserDataPruner service
 ResolvedDreamy_JazzT373032 Create a maintenance script to purge expired rows from the recentchanges table
 ResolvedDreamy_JazzT371724 Define virtual domains configuration for virtual-checkuser-global on WMF wikis
 ResolvedDreamy_JazzT368151 Add a shared table to CheckUser that records changes to different wikis per IP address of the user
 ResolvedDreamy_JazzT374530 Make probabilistic write to cuci_user disable-able via a config variable
 DeclinedPRODUCTION ERRORNoneT374687 Expectation (writes <= 0) by MediaWiki\MediaWikiEntryPoint::restInPeace not met (actual: {actualSeconds}):{query}
 ResolvedPRODUCTION ERRORDreamy_JazzT374994 CheckUser is attempting to write to cuci_user for users which have no central account
 ResolvedPRODUCTION ERRORDreamy_JazzT375063 Do not save data for the system users to cuci_user
 DuplicatePRODUCTION ERRORNoneT376458 Unable to find central ID for local user {username} when recording action in cuci_user table.
 ResolvedSecurityNoneT385734 Account auto-creations caused by import of page caused actor table rows and CheckUser result rows but no associated user table row
 ResolvedDreamy_JazzT375203 Run populateCentralCheckUserIndexTables.php on WMF wikis
 ResolvedDreamy_JazzT375221 Lots of "SQL query did not specify the caller" warnings
 ResolvedDreamy_JazzT375399 CheckUser tests failing when run using sqlite
 ResolvedTchandersT377482 Update ContributionsPager to allow subclasses more control over formatting

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Tchanders removed a subtask: T368151: Add a shared table to CheckUser that records changes to different wikis per IP address of the user.Aug 5 2024, 9:26 AM
Tchanders mentioned this in T356289: Create a special page for viewing global user contributions.Aug 6 2024, 12:59 PM
Tchanders updated the task description. (Show Details)
Tchanders updated the task description. (Show Details)Aug 6 2024, 1:55 PM
Tchanders added a parent task: T358048: Use Codex HtmlForm in Special:GlobalContributions.Aug 6 2024, 5:27 PM
Tchanders added a parent task: T358047: Add ToggleButtonGroup to Special:GlobalContributions for displaying results in a table.
Tchanders added a parent task: T371917: Use a time period field in Special:GlobalContributions instead of start/end date fields.
Tchanders removed a parent task: T337089: [Epic] Implement global contributions feature.
Dreamy_Jazz closed subtask T371724: Define virtual domains configuration for virtual-checkuser-global on WMF wikis as Resolved.Aug 19 2024, 2:17 PM
kostajh assigned this task to STran.Aug 20 2024, 1:31 PM

Assigning to @STran per Thalia's sabbatical document.

Dreamy_Jazz mentioned this in T373018: [Epic] Write to, populate, and purge data from the CheckUser central index tables.Aug 21 2024, 12:20 PM
Dreamy_Jazz removed a subtask: T371788: Update cuci_temp_edit table each time a temp user edits.Aug 21 2024, 12:29 PM
Dreamy_Jazz edited subtasks, added: T373018: [Epic] Write to, populate, and purge data from the CheckUser central index tables; removed: T371724: Define virtual domains configuration for virtual-checkuser-global on WMF wikis.
kostajh added a project: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).Aug 26 2024, 12:20 PM
STran moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Aug 29 2024, 1:58 PM
STran moved this task from Needs review to Priority Backlog on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.
Niharika added a project: CheckUser-GlobalContributions.Sep 4 2024, 5:23 PM
Niharika moved this task from Backlog to Pilot wiki (minor phase) blocker on the CheckUser-GlobalContributions board.Sep 4 2024, 5:35 PM
kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 16 2024, 8:45 AM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)); removed Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).Sep 16 2024, 10:11 AM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 10:21 AM
STran mentioned this in T375632: Return global contributions by an account given a username (temporary or registered).Sep 25 2024, 1:46 PM
Dreamy_Jazz closed subtask T373018: [Epic] Write to, populate, and purge data from the CheckUser central index tables as Resolved.Oct 4 2024, 10:58 AM
gerritbot added a comment.Oct 4 2024, 2:10 PM

Change #1077960 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] [WIP] Query contributions globally on Special:GlobalContributions

https://gerrit.wikimedia.org/r/1077960

gerritbot added a project: Patch-For-Review.Oct 4 2024, 2:10 PM
Niharika edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).Oct 8 2024, 10:32 AM
Niharika moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
gerritbot added a comment.Oct 8 2024, 2:56 PM

Change #1078697 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Update ContributionsPager to support Special:GlobalContributions

https://gerrit.wikimedia.org/r/1078697

gerritbot added a comment.Oct 10 2024, 4:22 PM

Change #1079317 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Initialise Special:GlobalContributions only if CentralAuth is loaded

https://gerrit.wikimedia.org/r/1079317

Tchanders updated the task description. (Show Details)Oct 10 2024, 4:33 PM

IP reveal is not available on this page (since IP look-ups that are not local would fail)

When searching for an IP address, this is not needed anyway. When searching for an IP range, the IP address for a particular contribution can be found by visiting the local wiki where the contribution was made.

gerritbot added a comment.Oct 10 2024, 4:38 PM

Change #1079321 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Remove IP reveal from Special:GlobalContributions

https://gerrit.wikimedia.org/r/1079321

gerritbot added a comment.Oct 10 2024, 5:01 PM

Change #1079317 abandoned by Tchanders:

[mediawiki/extensions/CheckUser@master] Initialise Special:GlobalContributions only if CentralAuth is loaded

Reason:

CentralAuth dependency was removed

https://gerrit.wikimedia.org/r/1079317

gerritbot added a comment.Oct 10 2024, 11:23 PM

Change #1079321 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove IP reveal from Special:GlobalContributions

https://gerrit.wikimedia.org/r/1079321

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 11 2024, 12:00 AM
gerritbot added a comment.Oct 11 2024, 5:51 PM

Change #1077960 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Query contributions globally on Special:GlobalContributions

https://gerrit.wikimedia.org/r/1077960

gerritbot added a comment.Oct 14 2024, 9:28 AM

Change #1079946 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] GlobalContributionsPager: Use a join instead of two queries

https://gerrit.wikimedia.org/r/1079946

kostajh closed subtask T356289: Create a special page for viewing global user contributions as Resolved.Oct 14 2024, 11:34 AM
gerritbot added a comment.Oct 14 2024, 3:54 PM

Change #1080066 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CheckUser@master] GlobalContributionsPager: Make use of the query builder construction utility

https://gerrit.wikimedia.org/r/1080066

gerritbot added a comment.Oct 14 2024, 4:29 PM

Change #1079946 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] GlobalContributionsPager: Use a join instead of two queries

https://gerrit.wikimedia.org/r/1079946

gerritbot added a comment.Oct 14 2024, 8:39 PM

Change #1080066 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IPContributions/GlobalContributions: Make use of the query builder construction utility

https://gerrit.wikimedia.org/r/1080066

gerritbot added a comment.Oct 15 2024, 5:38 AM

Change #1080108 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Split formatRow into separate methods

https://gerrit.wikimedia.org/r/1080108

gerritbot added a comment.Oct 15 2024, 6:08 AM

Change #1080112 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Support article link for foreign revision rows

https://gerrit.wikimedia.org/r/1080112

gerritbot added a comment.Oct 15 2024, 7:42 AM

Change #1080108 merged by jenkins-bot:

[mediawiki/core@master] ContributionsPager: Split formatRow into separate methods

https://gerrit.wikimedia.org/r/1080108

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.28; 2024-10-22); removed MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 15 2024, 8:00 AM
gerritbot added a comment.Oct 16 2024, 7:57 AM

Change #1080454 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Add ContributionsPager->isFromExternalWiki() helper function

https://gerrit.wikimedia.org/r/1080454

gerritbot added a comment.Oct 16 2024, 9:27 AM

Change #1080437 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Make formatRow safe for for external revisions

https://gerrit.wikimedia.org/r/1080437

gerritbot added a comment.Oct 16 2024, 11:33 AM

Change #1080620 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Show flags for external revisions

https://gerrit.wikimedia.org/r/1080620

gerritbot added a comment.Oct 16 2024, 12:28 PM

Change #1080630 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Support external revisions in ContributionsPager->formatVisibilityLink()

https://gerrit.wikimedia.org/r/1080630

gerritbot added a comment.Oct 16 2024, 4:40 PM

Change #1080761 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Show annotations for current external revisions

https://gerrit.wikimedia.org/r/1080761

gerritbot added a comment.Oct 16 2024, 4:40 PM

Change #1080762 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Add comment about external tags display

https://gerrit.wikimedia.org/r/1080762

gerritbot added a comment.Oct 16 2024, 4:40 PM

Change #1080763 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Show user links for external revisions

https://gerrit.wikimedia.org/r/1080763

gerritbot added a comment.Oct 16 2024, 4:40 PM

Change #1080764 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Add docs about external comments display

https://gerrit.wikimedia.org/r/1080764

Tchanders mentioned this in T377482: Update ContributionsPager to allow subclasses more control over formatting.Oct 17 2024, 4:15 PM
gerritbot added a comment.Oct 17 2024, 4:20 PM

Change #1081208 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP Update GlobalContributionsPager to format external revision rows properly

https://gerrit.wikimedia.org/r/1081208

gerritbot added a comment.Oct 18 2024, 7:12 AM

Change #1081314 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Support a source wiki field in ContributionsPager

https://gerrit.wikimedia.org/r/1081314

gerritbot added a comment.Oct 18 2024, 7:30 AM

Change #1081363 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Add source wiki to contributions on Special:GlobalContributions

https://gerrit.wikimedia.org/r/1081363

gerritbot added a comment.Oct 18 2024, 1:38 PM

Change #1080437 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Make formatRow safe for for external revisions

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080437

gerritbot added a comment.Oct 18 2024, 1:38 PM

Change #1078697 abandoned by Tchanders:

[mediawiki/core@master] Support diff/history, date, and source wiki for Special:GC external revs

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1078697

gerritbot added a comment.Oct 18 2024, 1:38 PM

Change #1080630 abandoned by Tchanders:

[mediawiki/core@master] Support external revisions in ContributionsPager->formatVisibilityLink()

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080630

gerritbot added a comment.Oct 18 2024, 1:39 PM

Change #1080454 abandoned by Tchanders:

[mediawiki/core@master] Add ContributionsPager->isFromExternalWiki() helper function

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080454

gerritbot added a comment.Oct 18 2024, 1:39 PM

Change #1080112 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Support article link for external revision rows

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080112

gerritbot added a comment.Oct 18 2024, 1:39 PM

Change #1080620 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Show flags for external revisions

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080620

gerritbot added a comment.Oct 18 2024, 1:39 PM

Change #1080761 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Show annotations for current external revisions

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080761

gerritbot added a comment.Oct 18 2024, 1:39 PM

Change #1080762 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Add comment about external tags display

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080762

gerritbot added a comment.Oct 18 2024, 1:39 PM

Change #1080763 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Show user links for external revisions

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080763

gerritbot added a comment.Oct 18 2024, 1:40 PM

Change #1080764 abandoned by Tchanders:

[mediawiki/core@master] ContributionsPager: Add docs about external comments display

Reason:

Moved formatting for external-wiki revisions to the extension: T377482

https://gerrit.wikimedia.org/r/1080764

STran moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 21 2024, 12:39 PM
gerritbot added a comment.Oct 21 2024, 1:06 PM

Change #1081208 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update GlobalContributionsPager to format external revision rows

https://gerrit.wikimedia.org/r/1081208

gerritbot added a comment.Oct 22 2024, 1:07 PM

Change #1082203 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@wmf/1.43.0-wmf.28] Support template overrides in ContributionsPager

https://gerrit.wikimedia.org/r/1082203

gerritbot added a comment.Oct 22 2024, 1:28 PM

Change #1081314 merged by jenkins-bot:

[mediawiki/core@master] Support template overrides in ContributionsPager

https://gerrit.wikimedia.org/r/1081314

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 22 2024, 2:00 PM
gerritbot added a comment.Oct 22 2024, 3:08 PM

Change #1081363 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add source wiki to contributions on Special:GlobalContributions

https://gerrit.wikimedia.org/r/1081363

gerritbot added a comment.Oct 23 2024, 6:36 AM

Change #1082328 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@wmf/1.43.0-wmf.28] Add source wiki to contributions on Special:GlobalContributions

https://gerrit.wikimedia.org/r/1082328

STran moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 23 2024, 7:48 AM
gerritbot added a comment.Oct 23 2024, 2:52 PM

Change #1082203 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.28] Support template overrides in ContributionsPager

https://gerrit.wikimedia.org/r/1082203

gerritbot added a comment.Oct 23 2024, 2:52 PM

Change #1082328 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.43.0-wmf.28] Add source wiki to contributions on Special:GlobalContributions

https://gerrit.wikimedia.org/r/1082328

Stashbot added a comment.Oct 23 2024, 2:53 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-23T14:53:19Z] <stran@deploy2002> Started scap sync-world: Backport for [[gerrit:1082203|Support template overrides in ContributionsPager (T356292)]], [[gerrit:1082328|Add source wiki to contributions on Special:GlobalContributions (T356292)]]

Stashbot added a comment.Oct 23 2024, 2:55 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-23T14:55:46Z] <stran@deploy2002> stran: Backport for [[gerrit:1082203|Support template overrides in ContributionsPager (T356292)]], [[gerrit:1082328|Add source wiki to contributions on Special:GlobalContributions (T356292)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 23 2024, 3:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-23T15:04:13Z] <stran@deploy2002> Finished scap sync-world: Backport for [[gerrit:1082203|Support template overrides in ContributionsPager (T356292)]], [[gerrit:1082328|Add source wiki to contributions on Special:GlobalContributions (T356292)]] (duration: 10m 53s)

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2024, 3:31 PM
Nardog subscribed.EditedOct 24 2024, 6:01 PM

<li> elements with "(current)" on Special:Contributions no longer have the mw-contributions-current class. The class is still in the code, so I assume this is by mistake and #1080108 had something to do with it.

Nardog added a comment.Oct 24 2024, 9:12 PM
In T356292#10260104, @Nardog wrote:

<li> elements with "(current)" on Special:Contributions no longer have the mw-contributions-current class. The class is still in the code, so I assume this is by mistake and #1080108 had something to do with it.

Reported as T378132: mw-contributions-current css class missing from Special:Contributions

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15); removed Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)).Oct 28 2024, 11:05 AM
kostajh moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.
kostajh closed subtask T377482: Update ContributionsPager to allow subclasses more control over formatting as Resolved.Oct 28 2024, 11:13 AM
kostajh moved this task from In progress to Done / QA on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Oct 28 2024, 4:34 PM
kostajh moved this task from Pilot wiki (minor phase) blocker to Done on the CheckUser-GlobalContributions board.Nov 5 2024, 8:31 AM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)); removed Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15).Nov 18 2024, 11:42 AM
Tchanders moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Dec 2 2024, 2:02 PM
dom_walden subscribed.
Acceptance criteria
  • GlobalContributionsPager is implemented, extending ContributionsPager
  • GlobalContributionsPager::doQuery logs access, similar to`IPContributionsPager`

I have raised T379766.

  • GlobalContributionsPager::getRevisionQuery is overridden to fetch the latest contributions by temporary accounts from a given IP or range. It makes use of the cuci_temp_edit table and possibly other optimizations discussed in T355672: Investigate: How to make the GUC query performant. This is the bulk of the work for this task.
  • Submitting the form with an IP address or range fetches the latest revisions from temporary accounts using those IP addresses for all wikis in this wiki farm (limit to 20 per wiki)

I have raised T381269.

  • Results are displayed in a paginated list and sorted by descending timestamp

Sometimes I don't see the pagination interface (e.g. "older #"). It seems to be if the limit is equal to or greater than 20 * the number of wikis which have contributions. I have raised T381271.

  • Visibility of contributions (hidden users, suppression, etc) works the same as for the other contributions special pages
  • IP reveal is not available on this page (since IP look-ups that are not local would fail)

Yep.

kostajh closed this task as Resolved.Dec 5 2024, 12:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits