Background
According to the IP reveal access policy, stewards and checkusers can automatically access IP reveal:
Steward and CheckUser
Access is automatically granted to users who are members of the steward and checkuser user groups. These users are expected to treat the IP addresses consistent with the Access to nonpublic data policy.
...as opposed to other groups, who need to check a preference:
Admin
Opt-in through Special:Preferences. [...]
However, the current implementation required everyone to check a preference, e.g. from AbstractTemporaryAccountHandler:
if ( !$this->permissionManager->userHasRight( $this->getAuthority()->getUser(), 'checkuser-temporary-account' ) || !$this->userOptionsLookup->getOption( $this->getAuthority()->getUser(), 'checkuser-temporary-account-enable' ) ) { throw new LocalizedHttpException( new MessageValue( 'checkuser-rest-access-denied' ), 403 ); }
What needs doing
Ideally, we shouldn't check the preference for users in groups who don't need it.
Rather than checking the group, which can get complicated as some a WMF-specific (see also T356294), perhaps we could define a new right that is given to groups who do not need to check the preference.
QA Results - Local
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | https://phabricator.wikimedia.org/T356304 here |
