Page MenuHomePhabricator
Create Task
Maniphest T356345

CodexModule: Consider warning or error when a CodexModule depends on @wikimedia/codex
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Making a CodexModule depend on @wikimedia/codex defeats the purpose of code splitting, because @wikimedia/codex loads the whole library. We should consider throwing a warning or an error if a CodexModule both uses codexComponents and lists @wikimedia/codex as a dependency.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CodexModule: Add exception if @wikimedia/codex is requiredmediawiki/coremaster+25 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Jan 31 2024, 11:03 PM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptJan 31 2024, 11:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF subscribed.Jan 31 2024, 11:27 PM
CCiufo-WMF subscribed.Feb 1 2024, 6:11 PM

@Catrope should this be under T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule?

CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.Feb 1 2024, 6:11 PM
Catrope added a parent task: T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule.Feb 1 2024, 7:43 PM

Yes it should, sorry. I have put it under there.

CCiufo-WMF moved this task from Triaging to Backlog on the Design-System-Team board.Feb 2 2024, 2:32 PM
CCiufo-WMF triaged this task as Medium priority.Feb 2 2024, 2:55 PM
CCiufo-WMF moved this task from Backlog to Up Next on the Design-System-Team board.
CCiufo-WMF moved this task from Backlog to Infrastructure on the Codex board.Feb 2 2024, 7:48 PM
CCiufo-WMF set the point value for this task to 2.Feb 5 2024, 6:45 PM
CCiufo-WMF moved this task from Up Next to DST-Sprint-16 (2024-02-05 to 2024-02-16) on the Design-System-Team board.
CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)); removed Design-System-Team.
• AnneT changed the task status from Open to In Progress.Feb 8 2024, 7:02 PM
• AnneT claimed this task.
• AnneT moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
gerritbot added a comment.Feb 8 2024, 9:56 PM

Change 999090 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] CodexModule: Add exception if @wikimedia/codex is required

https://gerrit.wikimedia.org/r/999090

gerritbot added a project: Patch-For-Review.Feb 8 2024, 9:56 PM
• AnneT moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.Feb 8 2024, 9:57 PM
gerritbot added a comment.Feb 9 2024, 5:00 PM

Change 999090 merged by jenkins-bot:

[mediawiki/core@master] CodexModule: Add exception if @wikimedia/codex is required

https://gerrit.wikimedia.org/r/999090

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2024, 5:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 9 2024, 8:01 PM
• AnneT closed this task as Resolved.Feb 13 2024, 10:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits