Page MenuHomePhabricator

CodexModule: Consider warning or error when a CodexModule depends on @wikimedia/codex
Closed, ResolvedPublic2 Estimated Story Points

Description

Making a CodexModule depend on @wikimedia/codex defeats the purpose of code splitting, because @wikimedia/codex loads the whole library. We should consider throwing a warning or an error if a CodexModule both uses codexComponents and lists @wikimedia/codex as a dependency.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CCiufo-WMF triaged this task as Medium priority.Feb 2 2024, 2:55 PM
CCiufo-WMF moved this task from Backlog to Up Next on the Design-System-Team board.
AnneT changed the task status from Open to In Progress.Feb 8 2024, 7:02 PM
AnneT claimed this task.

Change 999090 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] CodexModule: Add exception if @wikimedia/codex is required

https://gerrit.wikimedia.org/r/999090

Change 999090 merged by jenkins-bot:

[mediawiki/core@master] CodexModule: Add exception if @wikimedia/codex is required

https://gerrit.wikimedia.org/r/999090