| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Extract RefineSingleApp code from Refine | analytics/refinery/source | master | +788 -92 |
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T307500 Airflow Hackathon (May 2022) | |||
| Open | None | T307505 Refine jobs should be scheduled by Airflow | |||
| Resolved | JAllemandou | T356363 [Refine Refactoring] Refactor refinery code for compatibility with Airflow integration |
Event Timeline
Comment Actions
Change 1003745 had a related patch set uploaded (by Joal; author: Joal):
[analytics/refinery/source@master] [WIP] Extract RefineSingleApp code from Refine
Comment Actions
I had a question about this, because I just found out that refinery has its own email sending code. (re: https://gerrit.wikimedia.org/r/c/analytics/refinery/source/+/1014004)
Until this point, I was under the impression that the emails we were getting from refinery were the standard stdout/stderr based emails emitted by systemd timers.
Would we still want this integrated email functionality within refinery, when it's running under airflow?
Comment Actions
Nope, when running from Airflow, no email would get sent by the Refine process itself, but rather by Airflow :)
Comment Actions
Change #1003745 merged by Aqu:
[analytics/refinery/source@master] Extract RefineSingleApp code from Refine
Comment Actions
I'm not sure if this task is resolved? I think the relevant CR is Refactor Refine to be triggerd by Airflow (1016808), but it is currently attached to T356762: [Refine refactoring] Refine jobs should be scheduled by Airflow: implementation instead of this task?