Missing content-language header on PCS responses
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Logstash single document

message

Invalid value "undefined" for header "content-language"

trace

TypeError [ERR_HTTP_INVALID_HEADER_VALUE]: Invalid value "undefined" for header "content-language"
    at storeHeader (_http_outgoing.js:474:5)
    at processHeader (_http_outgoing.js:469:3)
    at ServerResponse._storeHeader (_http_outgoing.js:368:11)
    at ServerResponse.writeHead (_http_server.js:312:8)
    at handleResponse (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/hyperswitch/lib/server.js:220:22)
    at /srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/hyperswitch/lib/server.js:356:16
    at tryCatcher (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/srv/deployment/restbase/deploy-cache/revs/5f2756aec5f71f35aa56a2efb96e81b70033ffe0/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (internal/timers.js:461:21)

Impact

Blocks PCS switchover to core page HTML
Causes 500 errors on cached content in RESTBase level that needs manual purging

Notes

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add missing content-language header on page/summary	mediawiki/services/mobileapps	master	+14 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Stalled		None	T324931 Clean up open RESTBase related tickets
Open		None	T262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
Resolved		Jgiannelos	T344944 Move Parsoid endpoints out of RESTBase
Resolved		MSantos	T328559 Replace usage of RESTbase parsoid endpoints
Resolved		Jgiannelos	T339865 PCS should use parsoid endpoints in MediaWiki, not RESTbase
Resolved	PRODUCTION ERROR	Jgiannelos	T356369 Missing content-language header on PCS responses

Event Timeline

Jgiannelos created this task.Feb 1 2024, 6:17 AM

Jgiannelos triaged this task as Medium priority.

Restricted Application edited projects, added Wikimedia-production-error; removed Patch-For-Review. · View Herald TranscriptFeb 1 2024, 6:17 AM

Change 994991 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/mobileapps@master] Add missing content-language header on page/summary

https://gerrit.wikimedia.org/r/994991

gerritbot added a project: Patch-For-Review.Feb 1 2024, 10:09 AM

Jgiannelos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Feb 1 2024, 10:19 AM

Change 994991 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Add missing content-language header on page/summary

https://gerrit.wikimedia.org/r/994991

Tested the patch above on testing and run difftests for the failing titles on RESTBase for both summary and mobile-html and i don't see any references to content-language in the diffs.
I am still thinking about alternatives but this patch looks like a feasible way forward.