Page MenuHomePhabricator

Phorge (Phabricator) Code Sprint 2024
Closed, ResolvedPublic

Description

Current EventFuture Event →

Do you somehow think that Phabricator/Phorge is a bit weird? Wonderful!

Join our table and let's improve Phorge by at least 0.1 % this day.

Or, we can at least have a decent epic fail, but not alone this time.

A team of people who specialize in random yelling will help you channel any negative anger into something incredibly positive and constructive: a Task into upstream Phorge, and, ideally, finalize that into a patch, and, ideally, land that. Wow!

Anonymized testimonials

  • Luigi: «Before on secure.phabricator.com I couldn't even say hello or rescue any friend, I was off the castle. Then I joined Phorge and proposed a Super-Mario®-like sound for Workboard drag & drop and... it's still there pending for review after 9 months (like this patch blocked by governments: https://we.phorge.it/D25079 ) - But, I proposed 100+ other patches and they approved them all! so well, in Phorge they are good people. Don't join this project if you want patches related to 1-Up or Coins. But good for all the rest! Right? It's-a-me-Luigi!»
  • Pinuccio: «I work all the damn day on Phabricator/Phorge for a large organization that starts with W and ends with ikimedia Foundation and BELIEVE ME there were some things I wanted to change over the years and now I CAN DO IT - HONEST THAT'S GOOD - WE CAN DO IT. IT'S BEAUTIFUL - WOW!!!! - I HAVE 4 SECONDS LEFT OF RECORDING AND I'LL SAY IT AGAIN: IT'S BEAUT. * click *»
  • ... (add yourself here)

Activities Corner

Phorge has creative space for nice Wikimedian activities.

Example activities in Phorge:

More bonus activities involving Phorge:


And finally:

Post-Event Activity Report

🫠 Maximum Effort 🔝 leading to Minimum Result ⏬ Ranking

This ranking is dedicated to giving a prize to small things that required exaggerated human effort.

Please edit this section do add interesting things to be mentioned. No requirement. Just add in the list and talk about that.

Here the ranking "Maximum Effort 🔝 · Minimum Result ⏬",

Starting from the last position (that is, the maximum result):

[10th position] 🦊 A Wild Foxy Token Appeared in WMF

T364239: Add fox icon / badge to Phabricator

Just when we concluded our Code Boost, we stopped working. And, wow! and a Foxy Token appeared! 🦊

That was the MOST SURPRISING contribution ever, since really, we have done NOTHING for that! So this is the last place in our ranking "maximum effort, minimum result" since we did not make any effort. We just ate a doughnut, and this thing happened.

To try the foxy fox, open this fox-generator in another tab, and CLICK ON THAT FOXY FOX 🦊 - NOW: https://phabricator.wikimedia.org/token/give/PHID-TASK-nuog7n7fqceaw7jbfd3j/

We have done literally nothing to make it ↑↑↑ happen! Minimum effort (zero effort), maximum result! Bravissimi! Grazie @taavi!

[9th position] 🦄 Phorge Stickers

Phorge stickers lol.jpg (375×500 px, 106 KB)

For the FOSDEM 2024 we have done some crowdfounding and we arrived at 100 USD, and we invested this dirty money to produce stickers.

Unfortunately, this operation killed a bit our planet, so it's considered maximum effort, minimum result. They have also landed to Wikimedia Hackaton in Tallinn, just with extra planet killing flavor.

The design deserves a mention since it's literally the re-creation of a Phorge user interface, with the "indigo" Phorge color. If you have one sticker, keep that like a treasure, since 40 human-hours were invested in that design, and since nobody will give you back your planet.

Anyway, some people feel that stickers have brought in new contributors and thus have been somehow helpful. So, it is not at the top of this ranking Maximum Effort 🔝 · Minimum Result ⏬.

[8th position+ 💣 Cryptic Exception Messages in Saved Queries

Have you ever seen (since 2019) cryptic exception when listing things, while logged out? Like this one? Uh?

T15704-befoore.png (1×958 px, 168 KB)

Just 5 years later, this situation is now triaged and we have - at least - a couple of possible approaches and patches! Well done!

https://we.phorge.it/T15704

https://we.phorge.it/D25621

Upstreamed from: T217984: Listing tickets "Closed By: Current Viewer" while logged out causes PhabricatorTypeaheadInvalidTokenException: This datasource ("PhabricatorPeopleUserFunctionDatasource") can not evaluate the function "viewer(...)".

Trust us, too many resources and too many human beings were involved to troubleshoot and fix this. Still needing more code review. This is the reason of this position of our ranking.

Who could better than this? Uh?

[XXXth position] (Still Calculating the ranking position)

Have you ever uploaded a profile picture image in Phabricator/Phorge? Uh? Have you ever tried to delete your picture? :D

Thanks to albertoleoncio who reported this tricky issue in May 2023:

https://we.phorge.it/T15407

With great surprise, our GDPR-experts told to Alberto that "Phorge should be easily allow people to delete your stuff". Fortunately, Phorge was covering that deletion workflow, with this incredibly scaring but powerful feature (please look at that, trust me):

https://we.phorge.it/rP985eb26c7e32cdc19536769def6ab037645100fb

WARNING: The above commit contains scaring material suitable for people with command line access. Don't show that material to sensible persons.

Well, we have really not time to explain (it's a way to say that we have not understood how to fix that) but we proposed a fix for that!! And no, it's absolutely not complete to cover the original need of Alberto, but it's still something. So, still in a good position of maximum effort, minimum result:

https://we.phorge.it/D25622

[3rd position] (Still Calculating the ranking position)

Insert here something

[2nd position] (Still Calculating the ranking position)

Insert here something.

[1st position] "Access Denied: Restricted File" strings concatenated without whitespace

Have you ever seen such super-scarying warning, maybe since 2021, when you do not have enough permissions to do something? Have you ever noticed that there is a typo? That is, sentences have not one small space separators between them. Have you noticed? Uh? Uh?

Screenshot from 2021-10-14 16-30-18.png (682×960 px, 70 KB)

T293378: "Access Denied: Restricted File" strings concatenated without whitespace

That was upstream in April 2023:

https://we.phorge.it/T15270

Then a contributor proposed a patch but disappeared because it was extremely difficult to introduce that space in a secure way, but then other engineers joined, investing an incredible amount of time, to propose the definitive and secure one-line edit. Yes, we just introduced a space, a single space " ", in a safe way \o/

https://we.phorge.it/D25419

🎉 🏅 Well done, small cute space! This little space received a standing ovation during the wmhack final presentation {{citation needed}} and so here the 1st place 🏅

Event Timeline

Aklapper triggered indeed by Herald - funny this time :D

@valerio.bozzolan okay you've stumped me and a couple of other folx — how did you set that cover image on this task?? :D

okay you've stumped me and a couple of other folx — how did you set that cover image on this task?? :D

It worked thanks to love, plus, a drag & drop of an image on the Task, from the Workboard view :D I mean from here:

https://phabricator.wikimedia.org/project/board/6865/

(Uh! my Postfix esploded and I've not received notifications)

Task welcome upstream

Probably we will discuss for years about a good datasource configuration, to list "useful" stuff, since usefulness is subjective indeed. I definitevely love to see this.

valerio.bozzolan renamed this task from Phorge (Phabricator) Code Review Sprint to Phorge (Phabricator) Code Sprint.May 8 2024, 7:30 AM
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan added a subscriber: taavi.
valerio.bozzolan added a subscriber: waldyrious.

Again, please share a generous applause to the winner of the Phorge category "Maximum Efforts 🔝 leading to Minimum Result ⏬"

T293378: "Access Denied: Restricted File" strings concatenated without whitespace 🎉

Bravissimo! Congratulation to @waldyrious that obtained a standing ovation from wmhack \o/

Also deserving a mention that the same user collaborated on a partial rewrite of the become tool in Wikimedia Toolforge, and I can confirm that at least 6 hours were invested in rewriting 12 lines of file, but unfortunately this is not ready, so, out of the ranking, but it's probably a good material for the next year! :D

https://gerrit.wikimedia.org/r/c/labs/toollabs/+/1026967 🎉 (← out of the ranking, unofficial prize)

valerio.bozzolan renamed this task from Phorge (Phabricator) Code Sprint to Phorge (Phabricator) Code Sprint 2024.Apr 22 2025, 7:23 AM
valerio.bozzolan updated the task description. (Show Details)