Page MenuHomePhabricator

drop $wgUseSiteJs global
Closed, DeclinedPublic


$wgUseSiteJs was added by r6223. The idea was to avoid an extra web server HIT.

One usage removed with r107777. There is only one left in OutputPage to add the 'site' resource loader link.

I think we could drop that global just like we dropped $wgUseSiteCss.

Version: 1.20.x
Severity: enhancement



Related Objects


Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:06 AM
bzimport set Reference to bz33641.
bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Jan 10 2012, 4:41 PM
brion added a comment.Jan 10 2012, 8:49 PM

In the ResourceLoader world I don't think it actually adds a hit either, necessarily...

Indeed. Last I checked ResourceLoader doesn't output links for user/site js/css if the related pages on-wiki are empty or inexistent.

They could still serve as a way to prevent wiki-admins from writing JavaScript that is loaded on all pages for all users though, which I think is a valid use case that some mediawiki runners may wish to keep that way.

Marking wontfix per Krinkle comment #2