$wgUseSiteJs was added by r6223. The idea was to avoid an extra web server HIT.
One usage removed with r107777. There is only one left in OutputPage to add the 'site' resource loader link.
I think we could drop that global just like we dropped $wgUseSiteCss.
Version: 1.20.x
Severity: enhancement
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Use Kokkuri release v1.8.4 | repos/releng/kokkuri!91 | dancy | main-Ibf3c4133571b71f3056fa2921b0ceb814de2136c | main | |
| blubber.yaml: Use docker-registry.wikimedia.org/repos/releng/buildkit:wmf-v0.12.5-8 | repos/releng/kokkuri!90 | dancy | main-If363f1154883114dafe48f602663f67c049dfc3a | main | |
| Use buildkit wmf-v0.12.5-8 image from official WMF registry | repos/releng/gitlab-cloud-runner!326 | dancy | main-I128e7546237fd4cce3332d2ef2ebf2b5d1336172 | main | |
| Use WMF buildkit image wmf-v0.12.5-5 | repos/releng/gitlab-cloud-runner!324 | dancy | main-I3d8056f70dde8065831c66f7b895153e4877abd9 | main | |
| buildkitd: Use image tag wmf-v0.12.5-4 | repos/releng/gitlab-cloud-runner!323 | dancy | main-I57398e490b99840030fdf54c026444f7a1ffe5d9 | main | |
| wmf/Dockerfile: Change base image from bullseye to bookmark | repos/releng/buildkit!52 | dancy | wmf/v0.12-I8db6be1609c636416f2b3a20a2cf4f2adab4fdd4 | wmf/v0.12 | |
| buildkitd: Use registry.cloud.releng.team/repos/releng/buildkit:wmf-v0.12.5-2 | repos/releng/gitlab-cloud-runner!322 | dancy | main-Ic551a913dc10b902d579e75ef7d7ade08d920757 | main | |
| Use Kokkuri release v1.8.3 | repos/releng/kokkuri!89 | dduvall | main-I67eb63585fb0c9e6983ca08fa2701ec42a52d458 | main | |
| Use buildctl wmf-v0.12.5-2 | repos/releng/kokkuri!88 | dduvall | main-Ic0cd4326a3a7779d75542e2f7f1516af5e341a95 | main | |
| buildkitd: Use registry.cloud.releng.team/repos/releng/buildkit:wmf-v0.12.5-2 | repos/releng/gitlab-cloud-runner!318 | dancy | main-I91dcba1594bad5a8f8a8971c70f6636efe629e52 | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Declined | None | T35641 drop $wgUseSiteJs global |
In the ResourceLoader world I don't think it actually adds a hit either, necessarily...
Indeed. Last I checked ResourceLoader doesn't output links for user/site js/css if the related pages on-wiki are empty or inexistent.
They could still serve as a way to prevent wiki-admins from writing JavaScript that is loaded on all pages for all users though, which I think is a valid use case that some mediawiki runners may wish to keep that way.