Page MenuHomePhabricator

Styles are not loaded without JavaScript
Closed, ResolvedPublicBUG REPORT

Description

The styles for Special:QrCode are loaded along with the JavaScript and so during page load the QR code shifts from below the form to the right. Also, for users without JS enabled, the styles are never loaded.

This should be fixed by moving the styles to a styles-only module, and loading it separately.

Screenshot 2024-02-02 at 12-17-13 QR Code Generator - Dev wiki1.png (590×757 px, 39 KB)

Event Timeline

Change 1002928 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/UrlShortener@master] SpecialQrCode: Load styles separately from JS module

https://gerrit.wikimedia.org/r/1002928

MusikAnimal subscribed.

Great task for the Wishathon, but I'd rather get this fixed sooner than that.

Change 1002928 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@master] SpecialQrCode: Load styles separately from JS module

https://gerrit.wikimedia.org/r/1002928

dom_walden subscribed.

Loading Special:QrCode and Special:UrlShortener in Firefox with and without JS, they both look the same to me, including after submitting the form.

Test environment: https://en.wikipedia.beta.wmflabs.org UrlShortener 1.2.0 (15b7bc2) 10:27, 13 February 2024.