Page MenuHomePhabricator
Create Task
Maniphest T356660

Unset IPInfo as a BetaFeature and make available by default on wikis where temporary accounts are known
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Summary

Wikis with the BetaFeatures extension require IPInfo to be enabled as a beta feature before a user can use it.

Now that IPInfo is deployed everywhere, we should graduate it from BetaFeatures.

This should happen in tandem with the rollout of temporary accounts, because it narrows down IPInfo access.

Background

We want to simplify patrolling workflows as part of the temporary accounts deployment, so removing the step of enabling the beta feature will help.

The set of users allowed to access IP information is narrower on wikis where temporary accounts are known, as it needs to conform to our temporary account IP address access policy,
so we should remove the BetaFeature gating on such wikis only to avoid granting default IPInfo access to users that would then lose it after the rollout of temporary accounts.

Technical notes

  • Don't require BetaFeature opt-in for IPInfo access on wikis where temporary accounts are known (check via TempUserConfig::isKnown)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix and reenable IPInfoHandlerTestmediawiki/extensions/CheckUsermaster+8 -18
Introduce IPInfoPermissionManager servicemediawiki/extensions/IPInfomaster+313 -0
Graduate IPInfo out of beta when temporary users are knownmediawiki/extensions/IPInfomaster+229 -301
Skip IPInfo integration tests for handler signature changemediawiki/extensions/CheckUsermaster+3 -0
Remove IPInfo from BetaFeaturesmediawiki/extensions/IPInfomaster+54 -413
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 ResolvedNiharikaT324492 Temporary accounts - MVP
 In ProgressNiharikaT325451 [Epic] Users with right privileges are able to view IP addresses
 ResolvedkostajhT340895 [Epic] IP Info accommodations for temporary accounts
 Resolved• mszaboT349534 Display IPInfo for a temporary account on a new SpecialPage
 Resolved• mszaboT349535 Make the table on Special:IPInfo sortable on every column if a single page
 OpenNoneT349538 Add “Edits made using this IP” column to Special:IPInfo
 Resolved• mszaboT349540 Add "show IP" column to Special:IPInfo
Resolved• mszaboT349536 Create Special:IPInfo for displaying information about IP addresses used by a temporary user
 Resolved• mszaboT349716 Show IPInfo popup for temporary accounts
 ResolvedSTranT341395 Display Spur data on IPInfo infobox
 ResolvedTchandersT349723 Return Spur data from the IPInfo APIs
 ResolvedkostajhT354359 Update ProductionServices.php with proxy address for ipoid
 OpenNoneT378720 Include help text for every field on IP Information
 Resolved• mszaboT356105 Instrument data sources used in IPInfo
 DeclinedNoneT340628 Create mock provider for ipoid service requests
 ResolvedSTranT339330 Update ENV variables to match expected production variables
 InvalidNoneT339286 Allow IPInfo's infobox widget to display data from more than one data source
 ResolvedkostajhT339284 Deploy ipoid
 ResolvedkostajhT340984 Fix problems with data import
 ResolvedBUG REPORT• AGueyteT340178 "Column 'anonymous' cannot be null"
 DeclinedBUG REPORT• TThoabalaT340176 "Data too long for column 'behavior' at row 1"
 DeclinedBUG REPORTNoneT339837 "Data too long for column 'anonymous' at row 1"
 ResolvedBUG REPORT• TThoabalaT339359 'Parameter at position 2 is undefined\n' if tunnels.type is not set
 ResolvedBUG REPORT• AGueyteT339345 "Duplicate entry '0' for key 'behavior'"
 ResolvedBUG REPORT• TThoabalaT339343 "Column 'type' cannot be null"
 DeclinedBUG REPORT• TThoabalaT341605 Ipoid: ER_DATA_TOO_LONG
 DeclinedBUG REPORT• AGueyteT339325 "Duplicate entry '0' for key 'proxy'"
 InvalidBUG REPORTNoneT339324 "Data too long for column 'type' at row 1"
 InvalidNoneT345107 Update Tunnels Type schema VARBINARY value
 ResolvedBUG REPORT• TThoabalaT339073 Density imported incorrectly
 ResolvedSTranT344749 Refactor import-db and update-db into one script
 ResolvedSTranT341122 Implement daily data update routine
 ResolvedTchandersT344517 Fix statements generated for updated IP data
 ResolvedTchandersT344520 Remove temporary files to avoid taking up unnecessary disk space
 ResolvedSTranT344272 Use batching for daily data import
 ResolvedSTranT325630 Implement call to data vendor
 ResolvedTchandersT344499 Move behaviors/proxies/tunnels processing into an independent script
 DeclinedNoneT344939 Log when the lookup fails on attempting to INSERT to actor_data (because the proxy/behaviour doesn't exist)
 ResolvedTchandersT344921 Ensure dependent SQL statements are all run in the same batch
 ResolvedTchandersT344981 Map tables should not have null for any of their values
 ResolvedSTranT345757 Create orchestration script for daily data update
 ResolvedNoneT345761 Turn scripts into modules that export
 ResolvedSTranT345684 Implement batch tracking for imports
 ResolvedBUG REPORTTchandersT341660 Investigate non-deterministic behaviour of import
 ResolvedkostajhT341129 Setup spec.yaml
 ResolvedjijikiT341326 Deploy ipoid to staging on Kuberenetes
 ResolvedkostajhT339331 Prepare for initial data import on production servers
 ResolvedSTranT344941 Respond to data update and import errors
 DuplicateNoneT355429 data pipeline: Don't attempt to re-import current day if full import already existed
 ResolvedSTranT345156 DBA audit of ipoid database
 DuplicateSTranT345237 Investigate: Recovering from skipped updates when pulling from the daily feed
 ResolvedkostajhT346861 [M] Write CronJob configuration
 ResolvedjijikiT350903 Rename FEED_API_KEY
 ResolvedkostajhT348477 Update mariadb library to latest version 3 release
 ResolvedBUG REPORTkostajhT349056 [S] split: too many files
 ResolvedkostajhT349171 [M] Implement proxy configuration for kubernetes deployment
 DuplicateNiharikaT325456 [Epic] Display IP addresses for temp users in IP Info
Resolved• mszaboT349715 Show IPInfo infobox on Special:Contributions for temporary accounts
 DuplicateNoneT325661 Add TemporaryAccountHandler API endpoint
 DuplicateNoneT325662 Allow IPInfo's infobox widget to display data from more than one IP address
 ResolvedTchandersT327437 The CheckUser extension should provide IP addresses of a temporary account user, given a list of revision IDs
 ResolvedBUG REPORT• mszaboT378625 Special:IPInfo link missing from IP information infobox
 ResolvedNiharikaT373818 [Epic] Guidance for discovery of IP Reveal feature
 ResolvedTchandersT383391 Remove feature flag for showing temporary accounts onboarding dialog
 ResolvedDreamy_JazzT385701 CheckUser IP reveal guidance dialog: Make dialog only appear once for users on all wikis for a multi-wiki install
 ResolvedDreamy_JazzT385698 CheckUser IP reveal guidance dialog: Make IPInfo preference check apply globally if GlobalPreferences extension installed
 ResolvedBUG REPORTDreamy_JazzT298977 Make it possible to set the IPInfo user preference globally
 ResolvedkostajhT375084 [Epic] Graduate IP Info out of Beta features
 Resolved• mszaboT356660 Unset IPInfo as a BetaFeature and make available by default on wikis where temporary accounts are known

Event Timeline

Tchanders created this task.Feb 5 2024, 5:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2024, 5:16 PM
Tchanders updated the task description. (Show Details)Feb 5 2024, 5:17 PM
Dreamy_Jazz added a comment.Feb 7 2024, 11:10 AM

@Tchanders when we do this I would suggest also:

  • Updating the version number in extension.json to something other than 0.0.0 (as this is on all wikis so should probably have a useful version number here)
  • Updating https://www.mediawiki.org/wiki/Extension:IPInfo to no longer be marked as experimental considering it would no longer be behind betafeatures.
Dreamy_Jazz added a comment.Feb 7 2024, 8:06 PM

Also we should mark the IP Info REST APIs as internal for use only by IPInfo code, so that people do not try to use it for other things and expect announcements if want to modify the REST API.

• JayCano added a project: Temporary accounts.Sep 12 2024, 12:56 PM
kostajh added a project: Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).Sep 13 2024, 11:03 AM
kostajh added a subscriber: • JayCano.

@JayCano @Niharika as we are wrapping up IP Info work, I propose we finish up this task as well. Should be a small amount of work.

kostajh set the point value for this task to 1.Sep 13 2024, 11:03 AM
kostajh moved this task from Inbox to Backlog on the Temporary accounts board.
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 10:30 AM
Niharika moved this task from Ready to Priority Backlog on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 17 2024, 9:00 AM

Taking this out of the Ready column temporarily. We need to communicate we are going to do this before we actually take it out of beta as, after that, everyone will see the "IP Info Contributions" accordion on Special:Contributions for IPs. I think there's a couple of other minor things we should also do before we graduate it out of beta.

Niharika added a parent task: T375084: [Epic] Graduate IP Info out of Beta features.Sep 18 2024, 2:23 PM
kostajh added a comment.Sep 26 2024, 10:20 AM
In T356660#10151970, @Niharika wrote:

Taking this out of the Ready column temporarily. We need to communicate we are going to do this before we actually take it out of beta as, after that, everyone will see the "IP Info Contributions" accordion on Special:Contributions for IPs.

@Niharika Per meeting just now, are we ready to do this task?

I think there's a couple of other minor things we should also do before we graduate it out of beta.

Do we have a list of these things?

Niharika added a subscriber: sgrabarczuk.EditedSep 26 2024, 10:27 AM

@kostajh The blockers to doing this task are:

(I connected all these under the Epic)

Then we can graduate it out of Beta. In parallel we can start communicating that this is about to happen. CC @sgrabarczuk

kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Oct 8 2024, 10:21 AM
Niharika edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).Oct 8 2024, 10:30 AM
Niharika moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15); removed Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)).Oct 8 2024, 10:42 AM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)); removed Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15).Nov 18 2024, 12:01 PM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)); removed Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)); removed Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)).Nov 18 2024, 12:24 PM
Tchanders edited projects, added Temporary accounts (Major pilot wiki deployment); removed Temporary accounts.Nov 20 2024, 6:39 PM
Tchanders moved this task from Backlog to Planned on the Temporary accounts (Major pilot wiki deployment) board.Dec 5 2024, 4:53 PM
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Dec 9 2024, 9:44 PM
• mszabo changed the task status from Open to Stalled.Jan 9 2025, 1:24 PM
• mszabo subscribed.

Marking stalled as this is blocked by T375086 and T325451.

kostajh moved this task from Ready to Priority Backlog on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Jan 15 2025, 9:37 AM
Tchanders removed a project: Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).Jan 15 2025, 2:46 PM
Dreamy_Jazz added a subtask: T373818: [Epic] Guidance for discovery of IP Reveal feature.Feb 6 2025, 6:04 PM
Dreamy_Jazz mentioned this in T385698: CheckUser IP reveal guidance dialog: Make IPInfo preference check apply globally if GlobalPreferences extension installed.Feb 6 2025, 6:11 PM
Dreamy_Jazz removed a subtask: T373818: [Epic] Guidance for discovery of IP Reveal feature.
Dreamy_Jazz added a parent task: T298977: Make it possible to set the IPInfo user preference globally.
Dreamy_Jazz mentioned this in T298977: Make it possible to set the IPInfo user preference globally.Feb 6 2025, 6:14 PM
Dreamy_Jazz added a parent task: T383391: Remove feature flag for showing temporary accounts onboarding dialog.
kostajh changed the task status from Stalled to Open.Mar 19 2025, 11:43 AM
In T356660#10444342, @mszabo wrote:

Marking stalled as this is blocked by T375086 and T325451.

Clarification now exists in https://phabricator.wikimedia.org/T325451#10651235

gerritbot added a comment.Apr 30 2025, 1:08 PM

Change #1140176 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Remove IPInfo from BetaFeatures

https://gerrit.wikimedia.org/r/1140176

gerritbot added a project: Patch-For-Review.Apr 30 2025, 1:08 PM
• mszabo changed the task status from Open to In Progress.Apr 30 2025, 1:31 PM
• mszabo claimed this task.
• mszabo added a project: Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).
• mszabo moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)) board.
Tchanders moved this task from Planned to In progress on the Temporary accounts (Major pilot wiki deployment) board.Apr 30 2025, 4:20 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)); removed Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).May 5 2025, 6:50 AM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
kostajh added a parent task: T325451: [Epic] Users with right privileges are able to view IP addresses.May 5 2025, 8:59 AM
kostajh mentioned this in T375084: [Epic] Graduate IP Info out of Beta features.
gerritbot added a comment.May 15 2025, 2:52 PM

Change #1146647 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Graduate IPInfo out of beta when temporary users are known

https://gerrit.wikimedia.org/r/1146647

gerritbot added a comment.May 16 2025, 11:14 AM

Change #1146955 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CheckUser@master] Skip IPInfo integration tests for handler signature change

https://gerrit.wikimedia.org/r/1146955

gerritbot added a comment.May 16 2025, 11:14 AM

Change #1146956 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CheckUser@master] Fix and reenable IPInfoHandlerTest

https://gerrit.wikimedia.org/r/1146956

• mszabo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 16 2025, 12:21 PM
gerritbot added a comment.May 16 2025, 1:19 PM

Change #1140176 abandoned by Máté Szabó:

[mediawiki/extensions/IPInfo@master] Remove IPInfo from BetaFeatures

Reason:

Superseded by Ibb79f165f8f4eaf380d7d91ef1ebb2105433035a

https://gerrit.wikimedia.org/r/1140176

gerritbot added a comment.May 19 2025, 4:00 PM

Change #1147806 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Introduce IPInfoPermissionManager service

https://gerrit.wikimedia.org/r/1147806

gerritbot added a comment.May 20 2025, 8:45 AM

Change #1146955 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Skip IPInfo integration tests for handler signature change

https://gerrit.wikimedia.org/r/1146955

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 20 2025, 9:00 AM
gerritbot added a comment.May 20 2025, 11:35 AM

Change #1147806 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Introduce IPInfoPermissionManager service

https://gerrit.wikimedia.org/r/1147806

gerritbot added a comment.May 20 2025, 11:35 AM

Change #1146647 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Graduate IPInfo out of beta when temporary users are known

https://gerrit.wikimedia.org/r/1146647

gerritbot added a comment.May 20 2025, 11:35 AM

Change #1146956 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix and reenable IPInfoHandlerTest

https://gerrit.wikimedia.org/r/1146956

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 12:30 PM
• mszabo renamed this task from Unset IPInfo as a BetaFeature and make available by default to Unset IPInfo as a BetaFeature and make available by default on wikis where temporary accounts are known.May 21 2025, 12:54 PM
• mszabo updated the task description. (Show Details)
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)); removed Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)).May 25 2025, 6:58 PM
kostajh moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.
Tchanders added a comment.May 29 2025, 12:20 PM
In T356660#9520517, @Dreamy_Jazz wrote:

@Tchanders when we do this I would suggest also:

  • Updating the version number in extension.json to something other than 0.0.0 (as this is on all wikis so should probably have a useful version number here)

Should we do this after T375086: Bring IP Info access permissions to parity with the IP Reveal feature?

Should we do this once IPInfo is no longer a BetaFeatures extension (i.e. once we've rolled out temp accounts everywhere)?

gerritbot added a comment.May 29 2025, 12:27 PM

Change #1152056 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Mark REST API handler classes as internal, for IPInfo use only

https://gerrit.wikimedia.org/r/1152056

gerritbot added a project: Patch-For-Review.May 29 2025, 12:28 PM
Tchanders added a comment.May 29 2025, 12:28 PM
In T356660#9522464, @Dreamy_Jazz wrote:

Also we should mark the IP Info REST APIs as internal for use only by IPInfo code, so that people do not try to use it for other things and expect announcements if want to modify the REST API.

Done in https://gerrit.wikimedia.org/r/1152056

Dreamy_Jazz added a comment.May 29 2025, 12:30 PM
In T356660#10867333, @Tchanders wrote:
In T356660#9522464, @Dreamy_Jazz wrote:

Also we should mark the IP Info REST APIs as internal for use only by IPInfo code, so that people do not try to use it for other things and expect announcements if want to modify the REST API.

Done in https://gerrit.wikimedia.org/r/1152056

I think something would also be needed at https://en.wiktionary.org/w/index.php?api=mw-extra&title=Special%3ARestSandbox

Currently the REST APIs are listed there for use with no indication that they are for internal use only.

Dreamy_Jazz added a comment.May 29 2025, 12:31 PM
In T356660#10867288, @Tchanders wrote:
In T356660#9520517, @Dreamy_Jazz wrote:

@Tchanders when we do this I would suggest also:

  • Updating the version number in extension.json to something other than 0.0.0 (as this is on all wikis so should probably have a useful version number here)

Should we do this after T375086: Bring IP Info access permissions to parity with the IP Reveal feature?

Should we do this once IPInfo is no longer a BetaFeatures extension (i.e. once we've rolled out temp accounts everywhere)?

We should probably make the 1.0.0 release in extension.json once we mark the extension as no longer experimental.

Tchanders mentioned this in T395566: IPInfo: Release version 1.0.0.May 29 2025, 1:23 PM
In T356660#10867350, @Dreamy_Jazz wrote:
In T356660#10867288, @Tchanders wrote:
In T356660#9520517, @Dreamy_Jazz wrote:

@Tchanders when we do this I would suggest also:

  • Updating the version number in extension.json to something other than 0.0.0 (as this is on all wikis so should probably have a useful version number here)

Should we do this after T375086: Bring IP Info access permissions to parity with the IP Reveal feature?

Should we do this once IPInfo is no longer a BetaFeatures extension (i.e. once we've rolled out temp accounts everywhere)?

We should probably make the 1.0.0 release in extension.json once we mark the extension as no longer experimental.

Following some more discussion, I've made a separate task for this: T395566: IPInfo: Release version 1.0.0

Tchanders closed this task as Resolved.May 29 2025, 3:28 PM
Tchanders moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.
In T356660#10867345, @Dreamy_Jazz wrote:
In T356660#10867333, @Tchanders wrote:
In T356660#9522464, @Dreamy_Jazz wrote:

Also we should mark the IP Info REST APIs as internal for use only by IPInfo code, so that people do not try to use it for other things and expect announcements if want to modify the REST API.

Done in https://gerrit.wikimedia.org/r/1152056

I think something would also be needed at https://en.wiktionary.org/w/index.php?api=mw-extra&title=Special%3ARestSandbox

Currently the REST APIs are listed there for use with no indication that they are for internal use only.

Filed separately as T395576: Mark REST APIs as internal on Special:RestSandbox. I've re-tagged https://gerrit.wikimedia.org/r/1152056 against that (in case it's still useful).

I think we can close this task now. I double checked that IPInfo is not a beta feature on testwiki, where temp accounts are enabled, and still a beta feature on enwiki, where temp accounts are not enabled.

Tchanders mentioned this in T395784: IPInfo: Remove link to beta features preferences if IPinfo is not a beta feature.Jun 2 2025, 9:54 AM
Tchanders mentioned this in T395788: IPInfo: Enabling and disabling locally is not logged properly if IPInfo is not a beta feature.Jun 2 2025, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits