Migrate uses of codex-search in MobileFrontend to use CodexModule
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Feb 5 2024, 6:49 PM

Description

Background

Followup to T356678.

To unblock the Design systems team for the roll out of Codex with code-splitting support we need to replace the use of codex-search-styles with CodexModule as we did in T356678.

User story

As a mobile user, I want the mobile experience as optimized as possilbe.

Requirements

Replace the use of codex-search-styles with CodexModule

BDD

Feature: Optimize Mobile Experience with CodexModule

  Scenario: Verify replacement of codex-search-styles with CodexModule on mobile
    Given the user visits the mobile domain of Wikipedia
    When the user runs "mw.loader.getState('codex-search-styles')" in the JavaScript console
    Then the output should return "registered"

Design

No change

Test Steps

Test Case: Verify CodexModule Optimization on Mobile

Navigate to the mobile domain of Wikipedia using a mobile device or a mobile device emulator in a web browser.
Open the JavaScript console (this can usually be done via developer tools in most modern browsers).
Enter the command: mw.loader.getState('codex-search-styles') and press Enter.
AC1: Confirm that the console returns 'registered'.

QA Results - Beta

AC	Status	Details
1	✅	T356688#9730894

QA Results - Prod

AC	Status	Details
1	✅	T356688#9745180

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replace codex-search with codex module, add bundle size tests	mediawiki/extensions/MobileFrontend	master	+16 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		CCiufo-WMF	T356675 [EPIC] Deprecate the codex-search modules and migrate away from them
		Resolved		Jdlrobson	T356688 Migrate uses of codex-search in MobileFrontend to use CodexModule

Event Timeline

Catrope created this task.Feb 5 2024, 6:49 PM

Catrope mentioned this in T356675: [EPIC] Deprecate the codex-search modules and migrate away from them.Feb 5 2024, 6:54 PM

Jdlrobson triaged this task as Medium priority.Mar 13 2024, 5:10 PM

Jdlrobson added projects: Readers Essential Work 2025, Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6).

Jdlrobson moved this task from Backlog to Q3 (Jan-April) on the Readers Essential Work 2025 board.

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1); removed Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6).Mar 26 2024, 8:20 AM

Jdlrobson moved this task from Q3 (Jan-April) to Q4 (April-July) on the Readers Essential Work 2025 board.Apr 1 2024, 10:16 PM

After T356678 we are now loading Codex modules more than we need to on mobile page load so bumping priority.

Jdlrobson mentioned this in T356678: Migrate uses of codex-search in MinervaNeue to use CodexModule.Apr 5 2024, 6:19 AM

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 2.Apr 9 2024, 4:41 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.Apr 11 2024, 3:23 PM

bwang claimed this task.Apr 11 2024, 7:47 PM

Change #1019299 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Replace codex-search with codex module

https://gerrit.wikimedia.org/r/1019299

gerritbot added a project: Patch-For-Review.Apr 13 2024, 10:18 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.Apr 13 2024, 10:19 PM

bwang removed bwang as the assignee of this task.Apr 13 2024, 10:23 PM

bwang updated the task description. (Show Details)

bwang subscribed.

ovasileva assigned this task to Jdlrobson.Apr 15 2024, 5:26 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Apr 15 2024, 10:31 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.

Change #1019299 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace codex-search with codex module, add bundle size tests

https://gerrit.wikimedia.org/r/1019299

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 15 2024, 11:00 PM

@Jdlrobson, this needs more detail in the requirement. Some info on CodexModule and what to look for in the page source perhaps.

Done!

Jdlrobson lowered the priority of this task from High to Medium.Apr 15 2024, 11:31 PM

Edtadros updated the task description. (Show Details)Apr 19 2024, 9:58 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Test Case: Verify CodexModule Optimization on Mobile

Navigate to the mobile domain of Wikipedia using a mobile device or a mobile device emulator in a web browser.
Open the JavaScript console (this can usually be done via developer tools in most modern browsers).
Enter the command: mw.loader.getState('codex-search-styles') and press Enter.
✅ AC1: Confirm that the console returns 'registered'.

Edtadros updated the task description. (Show Details)Apr 19 2024, 10:01 PM

Jdlrobson closed this task as Resolved.Apr 19 2024, 10:05 PM

Jdlrobson claimed this task.

Gerges subscribed.Apr 22 2024, 2:20 PM

This task caused a bug T362986: Notifications do not appear well on the mobile version of RTL.

In T356688#9733145, @GergesSH wrote:

This task caused a bug T362986: Notifications do not appear well on the mobile version of RTL.

I'm not seeing anything that indicates this change caused T362986. Is there more context you can provide?

Okay I see you filed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1023066, but some context as to why reverting this change specifically will address the issue would be helpful.

Hi @CCiufo-WMF, The bug is caused by 1019299, I don't know what the actual reason was, but after reverting 1019299 the bug was resolved.

Looking.

I can confirm that reverting this patch addresses the problem.

It seems that when defining a module mobile.startup as a MediaWiki\\ResourceLoader\\CodexModule the styles interfere with the notification overlay.

The issue is now described in T363205.

Closing out this ticket again, as addressing the issue will be handled in T362986

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Test Case: Verify CodexModule Optimization on Mobile

Navigate to the mobile domain of Wikipedia using a mobile device or a mobile device emulator in a web browser.
Open the JavaScript console (this can usually be done via developer tools in most modern browsers).
Enter the command: mw.loader.getState('codex-search-styles') and press Enter.
✅ AC1: Confirm that the console returns 'registered'.

Edtadros updated the task description. (Show Details)Apr 25 2024, 3:35 PM

Edtadros mentioned this in T361456: Verify 1.43.0-wmf.1 deployment.Apr 25 2024, 4:07 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:58 PM

	F48635164: screenshot 266.png
	Apr 25 2024, 3:34 PM

	F47596438: screenshot 236.png
	Apr 19 2024, 10:00 PM

Migrate uses of codex-search in MobileFrontend to use CodexModuleClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Background

User story

Requirements

BDD

Design

Test Steps

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

Test Steps

Test Result - Prod

Test Steps

Migrate uses of codex-search in MobileFrontend to use CodexModule
Closed, ResolvedPublic2 Estimated Story Points
Actions

Related Objects
Search...