Edit section links do not display while using diff=curr
Closed, ResolvedPublic


Author: jelle.zijlstra

In pages like http://en.wikipedia.org/w/index.php?title=User_talk:Redrose64&diff=curr , no editsection links are shown, even though the page displayed is (by definition) the current version. Curiously, there are editsection links on http://en.wikipedia.org/w/index.php?title=User%20talk:Ucucha&diff=curr .

These links used to appear until earlier today. The bug is presumably caused by r108622, which merged r100756 and r92703 into 1.18wmf1. Not sure which of those is the culprit.

Version: unspecified
Severity: normal


bzimport set Reference to bz33671.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Jan 11 2012, 9:57 PM
Kipod added a comment.Jan 16 2012, 3:09 PM

for some very curious reason, this seem to be broweser-dependent: the same URL shows the editsection links with chrome and IE8, but they disapear with FF and IE9.

sandrobt.wiki wrote:

The same in it.wiki, this problem is pretty annoying, since it happens quite often to have a look to the last change of a page and see there is some corrections needed.

Amalthea.wikimedia wrote:

The edit links seem to be displayed correctly if a Special page is transcluded onto the page, like Ucucha does. Which is odd.

See two test pages, the second transcludes a special page and shows the section edit links:

Adding demon since I *guess* that this is caused by r92703, hopefully he can say.

mr.heat wrote:

Anybody working on this? I never get the edit-section links when I visit the pages on my watchlist. It should not be to hard to track this down since it *always* happens, at least in the German Wikipedia. Steps to reproduce:

  • Click "Random page".
  • Click "View history".
  • Click "prev" to see the diff for the last edit.

No edit-section links.

Looks like its fixed in 1.19. On http://labs.wikimedia.beta.wmflabs.org/wiki/Main_Page i get edit-sections on latest diffs.

Anomie added a comment.Feb 6 2012, 5:46 PM

(In reply to comment #6)

Looks like its fixed in 1.19. On
http://labs.wikimedia.beta.wmflabs.org/wiki/Main_Page i get edit-sections on
latest diffs.

Looks like it was (accidentally?) fixed in r103001 and r103002. Those revisions made the diff code create its own ParserOptions from its own context, instead of getting the ParserOptions from OutputPage which (since r92703) will always hide the section edit links.

I can't reproduce this on enwiki.

fixed in 1.19 so you can't reproduce anymore.

Anomie added a comment.Jun 9 2012, 3:45 PM

Since this is widely reported as fixed in 1.19, let's mark it that way.

Add Comment