ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Feb 6 2024, 7:34 PM

Description

Error

service.version: 1.42.0-wmf.17
trace.id: 12e0a86a-afe0-4955-9482-f74d9ee533f1
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.17/thumb.php on line 88 and exactly 2 expected

error.stack_trace

from /srv/mediawiki/php-1.42.0-wmf.17/includes/Request/WebRequest.php(258)
#0 /srv/mediawiki/php-1.42.0-wmf.17/thumb.php(88): MediaWiki\Request\WebRequest::getRequestPathSuffix(string)
#1 /srv/mediawiki/php-1.42.0-wmf.17/thumb.php(59): wfThumbHandle404()
#2 /srv/mediawiki/php-1.42.0-wmf.17/thumb.php(47): wfThumbMain()
#3 /srv/mediawiki/php-1.42.0-wmf.17/thumb_handler.php(36): require(string)
#4 /srv/mediawiki/w/thumb_handler.php(3): require(string)
#5 {main}

Impact

Notes

6 of these since deploying 1.42.0-wmf.17 (T354435) to group0.

Details

Request URL: https://office.wikimedia.org/w/thumb_handler.php/2/23/Why_web_performance_matters_at_Wikimedia.webm/120px--Why_web_performance_matters_at_Wikimedia.webm.jpg?20210126165815=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WebRequest: Fix default for backwards compat	mediawiki/core	wmf/1.42.0-wmf.17	+1 -1
	WebRequest: Fix default for backwards compat	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T354435: 1.42.0-wmf.17 deployment blockers
Mentioned Here: T354435: 1.42.0-wmf.17 deployment blockers

Event Timeline

brennen created this task.Feb 6 2024, 7:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2024, 7:34 PM

dancy merged a task: T356801: ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.17/thumb.php on line 88 and exactly 2 expected.Feb 6 2024, 7:35 PM

dancy subscribed.

Also getting this for img_auth.php:

service.version: 1.42.0-wmf.17
trace.id: 5e2e1e0b-9b16-41f8-831b-326ed8bc10d3
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.17/img_auth.php on line 72 and exactly 2 expected

error.stack_trace

from /srv/mediawiki/php-1.42.0-wmf.17/includes/Request/WebRequest.php(258)
#0 /srv/mediawiki/php-1.42.0-wmf.17/img_auth.php(72): MediaWiki\Request\WebRequest::getRequestPathSuffix(string)
#1 /srv/mediawiki/php-1.42.0-wmf.17/img_auth.php(51): wfImageAuthMain()
#2 /srv/mediawiki/w/img_auth.php(3): require(string)
#3 {main}

brennen renamed this task from ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.17/thumb.php on line 88 and exactly 2 expected to ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix().Feb 6 2024, 7:38 PM

The img_auth.php ones can be reproduced by loading the officewiki contact list, where indeed some images are giving a 500 with Fatal exception of type "ArgumentCountError".

brennen added a project: MediaWiki-Platform-Team.Feb 6 2024, 7:57 PM

brennen mentioned this in T354435: 1.42.0-wmf.17 deployment blockers.Feb 6 2024, 8:01 PM

This seems like a breaking change introduced in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/960185.

Change 997954 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] WebRequest: Fix default for backwards compat

https://gerrit.wikimedia.org/r/997954

gerritbot added a project: Patch-For-Review.Feb 6 2024, 8:04 PM

taavi added a project: MediaWiki-General.Feb 6 2024, 8:05 PM

Change 997876 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@wmf/1.42.0-wmf.17] WebRequest: Fix default for backwards compat

https://gerrit.wikimedia.org/r/997876

Change 997954 merged by jenkins-bot:

[mediawiki/core@master] WebRequest: Fix default for backwards compat

https://gerrit.wikimedia.org/r/997954

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 6 2024, 11:00 PM

Change 997876 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.17] WebRequest: Fix default for backwards compat

https://gerrit.wikimedia.org/r/997876

Mentioned in SAL (#wikimedia-operations) [2024-02-06T23:09:05Z] <brennen@deploy2002> Started scap: Backport for [[gerrit:997876|WebRequest: Fix default for backwards compat (T356800)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-06T23:10:36Z] <brennen@deploy2002> taavi and brennen: Backport for [[gerrit:997876|WebRequest: Fix default for backwards compat (T356800)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-06T23:18:07Z] <brennen@deploy2002> Finished scap: Backport for [[gerrit:997876|WebRequest: Fix default for backwards compat (T356800)]] (duration: 09m 02s)

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2024, 11:30 PM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.17; 2024-02-06); removed MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 7 2024, 2:00 AM

taavi closed this task as Resolved.Feb 7 2024, 8:20 AM

taavi claimed this task.

ArgumentCountError: Too few arguments to function MediaWiki\Request\WebRequest::getRequestPathSuffix()Closed, ResolvedPublicPRODUCTION ERRORActions