| • HMonroy | |
| Feb 7 2024, 5:56 AM |
| F46169058: 2024-04-12_13-30-44.png | |
| Apr 12 2024, 8:51 PM |
| F46168981: 2024-04-11_14-41-25.png | |
| Apr 12 2024, 8:51 PM |
| F46170247: 2024-04-12_13-43-35.png | |
| Apr 12 2024, 8:51 PM |
| F46170232: 2024-04-12_13-43-48.png | |
| Apr 12 2024, 8:51 PM |
| F46169964: 2024-04-12_13-41-03.png | |
| Apr 12 2024, 8:51 PM |
| F46169939: 2024-04-12_13-40-25.png | |
| Apr 12 2024, 8:51 PM |
| F46169929: 2024-04-12_13-39-53.png | |
| Apr 12 2024, 8:51 PM |
| F46169909: 2024-04-12_13-41-35.png | |
| Apr 12 2024, 8:51 PM |
Currently autosuggest populates in a notification toast when:
It should always use Dialog window. It should be the same message as the existing Notification toast.
Example when notification is loaded: https://commons.wikimedia.org/wiki/Category:Signal_towers
This task was created as part of Wikimedia Wishathon 2024
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | https://phabricator.wikimedia.org/T356837 here |
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Show 'already linked' message in Dialog rather than notification | repos/commtech/autosuggest-sitelink!50 | samwilson | already-linked-T356837 | main |
samwilson opened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/50
Show 'already linked' message in Dialog rather than notification
samtar merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/50
Show 'already linked' message in Dialog rather than notification
@Samwilson @HMonroy Autosuggest uses a dialog window beside a notification as seen in the screenshots below. I do have a possible design question on it at the bottom. Regardless this task will be moved to Done since the actual description passes. Thanks for all your work!
Status: ✅PASS
Environment: Meta Wiki
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 123, Safari 17.3
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://meta.wikimedia.org/wiki/WikiWomen%27s_Collaborative/Events/zh-cn
https://meta.wikimedia.org/wiki/Movement_Charter/Drafting_Committee/Announcement_2021_09_20/Short/fr
https://meta.wikimedia.org/wiki/Don%27t_be_a_jerk
✅AC1: https://phabricator.wikimedia.org/T356837
| Previous- New item | Current- New Item | Current- Item Link |
 |  |  |
| Vector 2022 | Vector 2010 | Minerva | Monobook | Timeless |
|  |  |  |  |
| Chrome | Firefox | Safari |
| F46168567} |  |  |
❓Possible minor design issue- Should you remove "Submit" and move the Help icon to that spot since there is no purpose for the "Submit" which is greyed out anyway?
 |  |
Good point about the unnecessary submit button. I've created a task: T362591: Remove submit button when nothing to submit