Page MenuHomePhabricator

Run a linter in CI to check if all Selenium tests have correct async/await
Open, Needs TriagePublic

Event Timeline

zeljkofilipin changed the task status from Open to In Progress.Feb 7 2024, 2:49 PM
zeljkofilipin triaged this task as Low priority.
zeljkofilipin created this task.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)

Were you thinking of doing this in eslint-config-wikimedia (or eslint-plugin-mediawiki)?

@Jdforrester-WMF at the moment, we're just looking if there's a tool that will find the kind of problems we've noticed.

I did some checks and for linting I think it will only help us if we used typescript with rules like @typescript-eslint/await-thenable, @typescript-eslint/require-await and @typescript-eslint/no-floating-promises.

zeljkofilipin changed the task status from In Progress to Open.Feb 9 2024, 1:25 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from Low to Needs Triage.

@Peter let's talk about moving to typescript during office hours next week.