Create a configuration value to control whether global account blocks are enabled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

To make it easier to deploy T17294, it should be possible to control whether a global account block applies to a given wiki. This allows deployment to be staged to avoid breakages on large wikis.

Acceptance criteria

Add a configuration value that controls whether to lookup and apply global blocks on accounts

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add wgGlobalBlockingAllowGlobalAccountBlocks	mediawiki/extensions/GlobalBlocking	master	+4 -0
	Pin wgGlobalBlockingAllowGlobalAccountBlocks as false on WMF wikis	operations/mediawiki-config	master	+14 -0

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T356936 Update GlobalBlocking services to support global block on accounts
Resolved	Dreamy_Jazz	T358157 Update the GlobalBlockManager service to support global blocks on accounts
Resolved	Dreamy_Jazz	T358155 Update GlobalBlockLookup service to support global blocks on accounts
Resolved	Dreamy_Jazz	T358725 Update the GlobalBlockingLinkBuilder service for global account blocks
Resolved	Dreamy_Jazz	T356923 Create a configuration value to control whether global account blocks are enabled
		· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 7 2024, 9:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2024, 9:55 PM

Dreamy_Jazz added a parent task: T17294: Allow globally blocking of accounts.Feb 7 2024, 9:56 PM

Dreamy_Jazz mentioned this in T356924: Deploy global account blocks to WMF wikis.

Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.Feb 7 2024, 9:58 PM

Dreamy_Jazz added a parent task: T356925: Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts.Feb 7 2024, 10:01 PM

Dreamy_Jazz removed a parent task: T17294: Allow globally blocking of accounts.Feb 7 2024, 10:18 PM

Dreamy_Jazz claimed this task.Feb 21 2024, 9:32 PM

Dreamy_Jazz added a parent task: T358150: Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Change 1005607 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Pin wgGlobalBlockingAllowGlobalAccountBlocks as false on WMF wikis

https://gerrit.wikimedia.org/r/1005607

gerritbot added a project: Patch-For-Review.Feb 21 2024, 9:48 PM

Change 1005607 merged by jenkins-bot:

[operations/mediawiki-config@master] Pin wgGlobalBlockingAllowGlobalAccountBlocks as false on WMF wikis

https://gerrit.wikimedia.org/r/1005607

Mentioned in SAL (#wikimedia-operations) [2024-02-21T21:58:25Z] <dreamyjazz@deploy2002> Started scap: Backport for [[gerrit:1005607|Pin wgGlobalBlockingAllowGlobalAccountBlocks as false on WMF wikis (T356923 T356924)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-21T21:59:58Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1005607|Pin wgGlobalBlockingAllowGlobalAccountBlocks as false on WMF wikis (T356923 T356924)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-21T22:08:42Z] <dreamyjazz@deploy2002> Finished scap: Backport for [[gerrit:1005607|Pin wgGlobalBlockingAllowGlobalAccountBlocks as false on WMF wikis (T356923 T356924)]] (duration: 10m 16s)

Change 1005614 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Add wgGlobalBlockingAllowGlobalAccountBlocks

https://gerrit.wikimedia.org/r/1005614

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 21 2024, 10:22 PM

Dreamy_Jazz edited parent tasks, added: T356936: Update GlobalBlocking services to support global block on accounts; removed: T358150: Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts.

Dreamy_Jazz added a parent task: T358155: Update GlobalBlockLookup service to support global blocks on accounts.Feb 21 2024, 10:42 PM

Dreamy_Jazz added a parent task: T358157: Update the GlobalBlockManager service to support global blocks on accounts.

Dreamy_Jazz removed a parent task: T356924: Deploy global account blocks to WMF wikis.

Dreamy_Jazz mentioned this in T356925: Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts.Feb 21 2024, 10:52 PM

Change 1005614 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add wgGlobalBlockingAllowGlobalAccountBlocks

https://gerrit.wikimedia.org/r/1005614

I would suggest that no QA is needed for this ticket because the configuration value is currently un-used. Testing that this configuration value works as expected will be done in other tickets.

Moving to Needs QA for QA to make this determination.

Dreamy_Jazz updated the task description. (Show Details)Feb 28 2024, 1:12 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2024, 1:31 PM

In T356923#9583459, @Dreamy_Jazz wrote:

I would suggest that no QA is needed for this ticket because the configuration value is currently un-used. Testing that this configuration value works as expected will be done in other tickets.

That makes sense. Thanks.

Dreamy_Jazz closed this task as Resolved.Feb 28 2024, 2:02 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Feb 28 2024, 5:01 PM

Dreamy_Jazz added a parent task: T358725: Update the GlobalBlockingLinkBuilder service for global account blocks.Feb 28 2024, 9:04 PM

Dreamy_Jazz mentioned this in T358773: Remove the global accounts block configuration flag.Feb 29 2024, 3:42 PM

Dreamy_Jazz mentioned this in T358725: Update the GlobalBlockingLinkBuilder service for global account blocks.Feb 29 2024, 10:41 PM

Dreamy_Jazz removed a parent task: T356925: Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts.Feb 29 2024, 10:52 PM