Page MenuHomePhabricator
Create Task
Maniphest T356929

Allow SpecialRemoveGlobalBlock to remove a global block on an account
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Dreamy_Jazz
Feb 7 2024, 10:17 PM
Tags
Referenced Files
F54981822: image.png
Jun 8 2024, 12:54 AM
F54980406: image.png
Jun 8 2024, 12:54 AM
F54980058: image.png
Jun 8 2024, 12:54 AM
F54980208: image.png
Jun 8 2024, 12:54 AM
F54981987: image.png
Jun 8 2024, 12:54 AM
F54982602: image.png
Jun 8 2024, 12:54 AM
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz

Description

The Special:RemoveGlobalBlock special page allows the removal of a global block. This should be updated to allow removing a global block on an account.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Special:RemoveGlobalBlock to support global account blocksmediawiki/extensions/GlobalBlockingmaster+63 -35
Test SpecialRemoveGlobalBlockmediawiki/extensions/GlobalBlockingmaster+93 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 ResolvedNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 OpenNoneT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 ResolvedDreamy_JazzT368949 [Epic] Implement global autoblocks from global user blocks
 DeclinedNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 ResolvedFeatureDreamy_JazzT17294 Allow globally blocking of accounts
 ResolvedDreamy_JazzT358777 Rename messages with the '-new' suffix to remove this suffix
 ResolvedDreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 ResolvedDreamy_JazzT358773 Remove the global accounts block configuration flag
 ResolvedDreamy_JazzT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 ResolvedMarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 ResolvedMarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 7 2024, 10:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2024, 10:17 PM
Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.Feb 7 2024, 10:17 PM
Dreamy_Jazz added a subtask: T356936: Update GlobalBlocking services to support global block on accounts.Feb 7 2024, 10:34 PM
Dreamy_Jazz closed subtask T356936: Update GlobalBlocking services to support global block on accounts as Resolved.Mar 27 2024, 9:40 AM
Dreamy_Jazz claimed this task.May 23 2024, 3:52 PM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
gerritbot added a comment.May 23 2024, 4:31 PM

Change #1035484 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Test SpecialRemoveGlobalBlock

https://gerrit.wikimedia.org/r/1035484

gerritbot added a project: Patch-For-Review.May 23 2024, 4:31 PM
gerritbot added a comment.May 23 2024, 4:45 PM

Change #1035526 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update Special:RemoveGlobalBlock to support global account blocks

https://gerrit.wikimedia.org/r/1035526

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 23 2024, 5:00 PM
Dreamy_Jazz moved this task from Sprint Shekere (13th May - 24th May) to Sprint Melodica (Jun 3 - Jun 14) on the Trust and Safety Product Sprint board.Jun 3 2024, 10:08 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 3 2024, 10:10 AM
gerritbot added a comment.Jun 5 2024, 1:53 PM

Change #1035484 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test SpecialRemoveGlobalBlock

https://gerrit.wikimedia.org/r/1035484

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 5 2024, 2:00 PM
gerritbot added a comment.Jun 5 2024, 4:27 PM

Change #1035526 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update Special:RemoveGlobalBlock to support global account blocks

https://gerrit.wikimedia.org/r/1035526

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2024, 4:30 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 5 2024, 4:30 PM
Dreamy_Jazz added a comment.Jun 6 2024, 10:03 AM

Suggested QA steps for patch demo, local wiki, or beta wikis:

  1. Log into an account with the steward group
  2. Perform a variety of global blocks using Special:GlobalBlock that will be used for testing, making sure to create blocks on at least one IP, IP range and account.
  3. Open Special:GlobalBlockList and verify that the blocks you performed appear in the list
  4. Open Special:GlobalUnblock and use the form to remove the blocks you applied in step 2
  5. Open Special:GlobalBlockList and verify that the blocks performed in step 2 are no longer present in the list
  6. Open Special:Log and verify that the log contains entries for each unblock made in step 4
  7. Re-open Special:GlobalUnblock and try to use the form again for the accounts/IPs/IP ranges you have already globally unblocked, and verify that an error indicating that they are not blocked appears
  8. Open Special:GlobalUnblock and enter the target #. Verify that the form returns an error saying the username is invalid
  9. Repeat step 8 with the a username that does not exist (you can check if it does not exist by loading Special:CentralAuth and entering the desired username into that page. If results appear, then try a different username)
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 8 2024, 12:54 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

image.png (994×1 px, 125 KB)

image.png (754×1 px, 289 KB)

image.png (617×1 px, 264 KB)

image.png (863×545 px, 207 KB)

image.png (876×473 px, 245 KB)

image.png (608×1 px, 220 KB)

Dreamy_Jazz closed this task as Resolved.Jun 18 2024, 1:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits