Page MenuHomePhabricator

Add gbw_target_central_id to global_block_whitelist table on WMF wikis
Closed, ResolvedPublic

Description

  1. ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/bdfa4a01272c793e190cbbf0169104a1f9a385e8/sql/mysql/patch-add-gbw_target_central_id.sql
  2. Where to run those changes: All (excluding the centralauth DB)
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes.
  5. If the schema change has been tested already on some of the test/beta wikis: This change has been applied to the betawikis by update.php
  6. If the data should be made available on the labs replicas and/or dumps: As far as I am aware this table is public and I see no reason for this column not to be on labs replicas and/or dumps.
The output of describe global_block_whitelist; from betawikis
MariaDB [enwiki]> describe global_block_whitelist;
+-----------------------+------------------+------+-----+---------+-------+
| Field                 | Type             | Null | Key | Default | Extra |
+-----------------------+------------------+------+-----+---------+-------+
| gbw_id                | int(11)          | NO   | PRI | NULL    |       |
| gbw_address           | varbinary(255)   | NO   |     | NULL    |       |
| gbw_by                | int(11)          | NO   | MUL | NULL    |       |
| gbw_by_text           | varbinary(255)   | NO   |     | NULL    |       |
| gbw_reason            | varbinary(767)   | NO   |     | NULL    |       |
| gbw_expiry            | binary(14)       | NO   |     | NULL    |       |
| gbw_target_central_id | int(10) unsigned | NO   |     | 0       |       |
+-----------------------+------------------+------+-----+---------+-------+
7 rows in set (0.002 sec)

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • labtestwiki

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenSkizzerz
OpenDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedDreamy_Jazz
OpenNone
OpenDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedMarostegui

Event Timeline

Marostegui triaged this task as Medium priority.Feb 8 2024, 12:09 PM
Marostegui moved this task from Triage to Ready on the DBA board.
Marostegui subscribed.

This is a pretty small table so we should be able to get this done on the masters with replication I guess.

Change 998870 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] filtered_tables.txt: Add new column

https://gerrit.wikimedia.org/r/998870

Change 998870 merged by Marostegui:

[operations/puppet@production] filtered_tables.txt: Add new column

https://gerrit.wikimedia.org/r/998870

Marostegui updated the task description. (Show Details)
Marostegui updated the task description. (Show Details)
Marostegui updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:03:25Z] <marostegui> dbmaint Schema change on s1@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:03:30Z] <marostegui> dbmaint Schema change on s2@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:03:34Z] <marostegui> dbmaint Schema change on s6@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:03:37Z] <marostegui> dbmaint Schema change on s8@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:08:28Z] <marostegui> dbmaint Schema change on s7@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:13:51Z] <marostegui> dbmaint Schema change on s5@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:39:19Z] <marostegui> dbmaint Schema change on s4@codfw T356988

Mentioned in SAL (#wikimedia-operations) [2024-02-08T15:41:39Z] <marostegui> dbmaint Schema change on s3@codfw T356988

Started the deployment in s3, it will take several hours. Should be done by the UTC morning.

Marostegui updated the task description. (Show Details)

All done

Thanks for the quick schema changes.