FlaggedRevs uses deprecated ContentRenderer::getParserOutput with revision id, breaks CI
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	awight
	Feb 8 2024, 2:49 PM

Description

Seen blocking merges in the Popups repo:

00:06:20.785 1) FlaggedRevsBackendTest::testParseStableRevisionPooled
00:06:20.785 Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from FlaggedRevs::parseStableRevision in /workspace/src/extensions/FlaggedRevs/includes/backend/FlaggedRevs.php at line 381]
00:06:20.786 
00:06:20.786 /workspace/src/includes/debug/MWDebug.php:378
00:06:20.786 /workspace/src/includes/debug/MWDebug.php:349
00:06:20.786 /workspace/src/includes/debug/MWDebug.php:230
00:06:20.786 /workspace/src/includes/GlobalFunctions.php:773
00:06:20.786 /workspace/src/includes/content/Renderer/ContentRenderer.php:57
00:06:20.786 /workspace/src/extensions/FlaggedRevs/includes/backend/FlaggedRevs.php:381
00:06:20.786 /workspace/src/extensions/FlaggedRevs/includes/backend/FlaggedRevs.php:291
00:06:20.786 /workspace/src/includes/poolcounter/PoolCounterWorkViaCallback.php:73
00:06:20.786 /workspace/src/includes/poolcounter/PoolCounterWork.php:172
00:06:20.786 /workspace/src/extensions/FlaggedRevs/includes/backend/FlaggedRevs.php:310
00:06:20.786 /workspace/src/extensions/FlaggedRevs/tests/phpunit/integration/FlaggedRevsBackendTest.php:50
00:06:20.786 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Do not hard deprecate passing an int to ContentRenderer::getParserOutput	mediawiki/core	master	+1 -2
	Fix deprecated call to getParserOutput with revid	mediawiki/extensions/FlaggedRevs	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T357006 FlaggedRevs uses deprecated ContentRenderer::getParserOutput with revision id, breaks CI
		Resolved	PRODUCTION ERROR	Umherirrender	T358243 PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id

Event Timeline

awight created this task.Feb 8 2024, 2:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2024, 2:49 PM

Also breaks CheckUser extension CI.

Change 998942 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/FlaggedRevs@master] Fix deprecated call to getParserOutput with revid

https://gerrit.wikimedia.org/r/998942

gerritbot added a project: Patch-For-Review.Feb 8 2024, 2:59 PM

taavi triaged this task as Unbreak Now! priority.Feb 8 2024, 3:07 PM

Change 998948 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] Do not hard deprecate passing an int to ContentRenderer::getParserOutput

https://gerrit.wikimedia.org/r/998948

Change 998948 merged by jenkins-bot:

[mediawiki/core@master] Do not hard deprecate passing an int to ContentRenderer::getParserOutput

https://gerrit.wikimedia.org/r/998948

Change 998942 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Fix deprecated call to getParserOutput with revid

https://gerrit.wikimedia.org/r/998942

matmarex closed this task as Resolved.Feb 8 2024, 4:01 PM

matmarex subscribed.

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 4:30 PM

In T357006#9525115, @Dreamy_Jazz wrote:

Also breaks CheckUser extension CI.

Can you open a separate bug for that? CheckUser doesn't seem to call getParserOutput anywhere.

In T357006#9525715, @cscott wrote:

In T357006#9525115, @Dreamy_Jazz wrote:

Also breaks CheckUser extension CI.

Can you open a separate bug for that? CheckUser doesn't seem to call getParserOutput anywhere.

This was because the FlaggedRevs extension is a dependency for CheckUser in CI, which means that that test from FlaggedRevs that failed was also run in CI for CheckUser changes. As long as it is fixed in FlaggedRevs, then it should also fix CheckUser CI.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 8 2024, 5:00 PM

Got it, thanks!

hashar mentioned this in T358243: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id.Feb 22 2024, 4:30 PM

hashar added a subtask: T358243: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id.

cscott closed subtask T358243: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id as Resolved.Feb 28 2024, 6:23 PM