| valerio.bozzolan | |
| Feb 8 2024, 3:16 PM |
| F41815976: Phabricator Calendar strange Tags default.png | |
| Feb 8 2024, 3:16 PM |
Steps to reproduce:
What happens:
See the "Tags" field here:
What should happen instead:
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| calendar: Update PhID used to filter default view | repos/phabricator/phabricator!34 | bd808 | work/bd808/T357014 | wmf/stable |
[16:57] < bd808> I'm poking around to see if I can figure out how the month view shared search got that project added to it. [16:58] < taavi> I have a feeling something is confusing that milestone with the #events tag (https://phabricator.wikimedia.org/project/view/2552/) [17:00] < bd808> interesting theory. I wonder what would happen if we change that archived tag's value? [17:04] < bd808> I renamed https://phabricator.wikimedia.org/project/manage/3878/ to "GLAM Events", but the https://phabricator.wikimedia.org/calendar/query/month/ shared query is still using it as the stored value for tags in the query.
The theory is that events is actually expected to be the default for the "Tags" field in that saved, shared query rather than https://phabricator.wikimedia.org/project/manage/3878/. The events tag was created by @mmodell with the description "The default calendar views are filtered to show only the events with this tag. Tag events that are of a general interest with #events. For special-interest events, consider using a team project tag instead."
This was the last task about changing it to events T343258: Filter default Phabricator calendar view to show items tagged with #events only
That task also explains what needs to be fixed. In https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/10 @Aklapper made PhID PHID-PROJ-5xclne2kzgjcckhqfzsd the default tag value in the stored search. Unfortunately, that PhID belongs to the WMSE-FindingGLAMs-2018 (GLAM Events) tag. The PhID of the events tag is PHID-PROJ-vwfungpqurhlzssxxs6a.
bd808 opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/34
calendar: Update PhID used to filter default view
brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/34
calendar: Update PhID used to filter default view