Page MenuHomePhabricator

Empty div displayed under 1000px
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Assigned To
Authored By
AAlhazwani-WMF
Feb 8 2024, 4:22 PM
Referenced Files
F42029198: screenshot 541.png
Feb 21 2024, 10:26 PM
F42029197: screenshot 542.png
Feb 21 2024, 10:26 PM
F41833486: screenshot 466.png
Feb 10 2024, 12:49 AM
F41833485: screenshot 465.png
Feb 10 2024, 12:49 AM
F41833484: screenshot 464.png
Feb 10 2024, 12:49 AM
F41816561: image.png
Feb 8 2024, 4:23 PM
Tokens
"100" token, awarded by AAlhazwani-WMF.

Description

Steps to replicate the issue (include links if applicable):

What happens?:

There's an empty div under the toolbar .vector-sticky-pinned-container that pushes the content down by 16px

What should have happened instead?:

If the div is empty is should not be displayed.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (1×3 px, 1 MB)

QA Results - Beta

ACStatusDetails
1T357022#9530882

QA Results - Prod

ACStatusDetails
1T357022#9565480

Event Timeline

Change 998998 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix extra space from pinned sticky container

https://gerrit.wikimedia.org/r/998998

it was faster to put up a fix than to update the task description with my analysis haha

Jdlrobson triaged this task as Medium priority.
Jdlrobson set the point value for this task to 1.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.

Change 998998 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix extra space from pinned sticky container

https://gerrit.wikimedia.org/r/998998

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a random article https://en.wikipedia.org/wiki/Special:Random
Resize the browser window so that the viewport is <1000px
✅ AC1: If the div is empty is should not be displayed.

screenshot 464.png (1×979 px, 158 KB)

screenshot 465.png (1×978 px, 156 KB)

screenshot 466.png (1×966 px, 336 KB)

ovasileva claimed this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a random article https://en.wikipedia.org/wiki/Special:Random
Resize the browser window so that the viewport is <1000px
✅ AC1: If the div is empty is should not be displayed.

screenshot 542.png (1×979 px, 497 KB)

screenshot 541.png (1×986 px, 516 KB)