Page MenuHomePhabricator
Create Task
Maniphest T357149

[DOT] Perform necessary redirect after editing terms in legacy termbox
Closed, ResolvedPublic
Actions

Description

The legacy termbox can make several edits, and T357024 is done, the first of these edits may create a temporary account and return a URL that we should redirect to, to complete the temporary account login with CentralAuth. We should redirect to that URL as soon as all edits are done (when we would otherwise leave “edit mode”).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Process CentralAuth redirects in Wikibase View for TempUsersmediawiki/extensions/Wikibasemaster+409 -61
Change TempUserWatcher to ValueChangeResult in ToolbarView..removemediawiki/extensions/Wikibasemaster+18 -10
Set returnto target for anonymous editswikibase/javascript-apimaster+22 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 9 2024, 4:21 PM
Lucas_Werkmeister_WMDE mentioned this in T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions.
Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.Feb 9 2024, 4:26 PM
ArthurTaylor moved this task from Incoming to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Feb 12 2024, 7:42 AM
Lucas_Werkmeister_WMDE moved this task from [DOT] By Project to [DOT] Prioritized on the wmde-wikidata-tech board.Feb 12 2024, 10:45 AM
ArthurTaylor edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.Feb 13 2024, 8:10 AM
ArthurTaylor moved this task from In Task Breakdown to Ready for Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Maintenance_bot moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Feb 13 2024, 8:29 AM
ArthurTaylor claimed this task.Feb 20 2024, 8:47 AM
ArthurTaylor moved this task from Ready for Development to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Feb 21 2024, 12:16 PM

Change 1005496 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Process CentralAuth redirects in legacy termbox for TempUsers

https://gerrit.wikimedia.org/r/1005496

gerritbot added a project: Patch-For-Review.Feb 21 2024, 12:16 PM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 21 2024, 1:35 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
Lucas_Werkmeister_WMDE claimed this task.Feb 21 2024, 4:58 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor claimed this task.Feb 23 2024, 10:31 AM
ArthurTaylor moved this task from In Peer Review to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Feb 23 2024, 2:16 PM

Change 1005996 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[wikibase/javascript-api@master] Set returnto target for anonymous edits

https://gerrit.wikimedia.org/r/1005996

ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 23 2024, 2:40 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor claimed this task.Feb 26 2024, 10:02 AM
ArthurTaylor moved this task from Ready for Peer Review to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Feb 26 2024, 4:32 PM

Change 1005996 merged by jenkins-bot:

[wikibase/javascript-api@master] Set returnto target for anonymous edits

https://gerrit.wikimedia.org/r/1005996

gerritbot added a comment.Feb 27 2024, 5:09 PM

Change 1005496 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Process CentralAuth redirects in Wikibase View for TempUsers

https://gerrit.wikimedia.org/r/1005496

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2024, 5:30 PM
gerritbot added a comment.Feb 28 2024, 11:57 AM

Change 1007313 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Change TempUserWatcher to ValueChangeResult in ToolbarViewController.remove

https://gerrit.wikimedia.org/r/1007313

gerritbot added a project: Patch-For-Review.Feb 28 2024, 11:57 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 28 2024, 12:50 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Feb 29 2024, 2:48 PM

Change 1007313 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Change TempUserWatcher to ValueChangeResult in ToolbarView..remove

https://gerrit.wikimedia.org/r/1007313

Maintenance_bot removed a project: Patch-For-Review.Feb 29 2024, 3:30 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 29 2024, 4:16 PM
Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor.
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

I think this is done and can be verified as part of the parent task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits