Page MenuHomePhabricator

[EPIC] Use ES6 features in MobileFrontend
Closed, DeclinedPublic

Description

  • object shorthand
  • classes
  • arrow functions
  • const/let
  • string templates

Event Timeline

Change 999985 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MobileFrontend@master] Use ES6 features in mobile.startup

https://gerrit.wikimedia.org/r/999985

Change 999985 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use ES6 features in mobile.startup

https://gerrit.wikimedia.org/r/999985

Jdlrobson claimed this task.

Change 1003805 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MobileFrontend@master] Use ES6 modules in MobileFrontend

https://gerrit.wikimedia.org/r/1003805

Jdlrobson renamed this task from Use ES6 features in MobileFrontend to [EPIC] Use ES6 features in MobileFrontend.Feb 15 2024, 6:01 PM
Jdlrobson reopened this task as Open.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Epic.

Change 1004296 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MobileFrontend@master] WIP Use ES6 classes in MobileFrontend

https://gerrit.wikimedia.org/r/1004296

Too broad a task IMO. @simon04 I think it would be better to focus on T281930 but I will review incremental patches that migrate us to ES6 provided they are small and scoped to one feature at a time (rather than migrating the entire codebase in one go!)

Change #1003805 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Use ES6 modules in MobileFrontend

Reason:

Abandoning for now as I don't think we can do this right now. Thanks for writing this patch it will be useful to refer back to from the Phabricator patch when we might be in a better place.

I do think adoption of ES6 classes as in your other patch (and let/const etc) are still a good idea so would encourage you to keep working on that patch and others! (perhaps using eslint as a driver!)

https://gerrit.wikimedia.org/r/1003805