Page MenuHomePhabricator
Create Task
Maniphest T357212

Regression: Can't toggle advanced mode on Special:MobileOptions
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue:

What happens?:
The toggle hasn't changed. On Chromium, the toggle does change if you refresh the page. On Firefox it doesn't.

What should have happened instead?:
The option gets toggled.

Other information:
It appears the page tries to reload itself BEFORE the options API request is sent, which cancels the request. You can confirm this by running addEventListener('beforeunload', e=>e.preventDefault()); in browser console while XHRs are logged.

QA Results - Beta

ACStatusDetails
1✅T357212#9540298

QA Results - Prod

ACStatusDetails
1✅T357212#9540313

Details

Other Assignee
Jdrewniak
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1mediawiki/extensions/MobileFrontendwmf/1.42.0-wmf.17+10 -10
Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1mediawiki/extensions/MobileFrontendmaster+10 -11
Callback should only be run after completion of API save requestmediawiki/skins/Vectormaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Nardog created this task.Feb 10 2024, 6:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2024, 6:08 PM
Nardog added a project: Advanced Mobile Contributions.Feb 10 2024, 6:09 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3).Feb 10 2024, 6:27 PM
Jdlrobson subscribed.

Thanks for creating this bug - I can also replicate. Just to confirm - the functionality seems to be working but for me the toggle looks incorrect? Is the following how it works for you?

Nardog added a comment.Feb 10 2024, 6:36 PM

It seems on Chromium the request does go through, so the toggling does occur. On Firefox it doesn't.

Nardog updated the task description. (Show Details)Feb 10 2024, 6:41 PM
Jdlrobson triaged this task as High priority.Feb 12 2024, 3:31 PM
gerritbot added a comment.Feb 12 2024, 4:54 PM

Change 1002586 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Callback should only be run after completion of API save request

https://gerrit.wikimedia.org/r/1002586

Jdlrobson renamed this task from Can't toggle advanced mode on Special:MobileOptions to Regression: Can't toggle advanced mode on Special:MobileOptions.Feb 12 2024, 4:54 PM
gerritbot added a project: Patch-For-Review.Feb 12 2024, 4:54 PM
Jdlrobson claimed this task.Feb 12 2024, 6:27 PM
Jdlrobson set the point value for this task to 2.
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3) board.
Jdlrobson updated Other Assignee, added: Jdrewniak.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3) board.Feb 12 2024, 7:07 PM
gerritbot added a comment.Feb 12 2024, 7:35 PM

Change 1002586 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Callback should only be run after completion of API save request

https://gerrit.wikimedia.org/r/1002586

gerritbot added a comment.Feb 12 2024, 7:40 PM

Change 1002603 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1

https://gerrit.wikimedia.org/r/1002603

gerritbot added a comment.Feb 12 2024, 7:42 PM

Change 1002607 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.17] Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1

https://gerrit.wikimedia.org/r/1002607

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3) board.Feb 12 2024, 7:50 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 12 2024, 8:00 PM
gerritbot added a comment.Feb 12 2024, 8:09 PM

Change 1002603 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1

https://gerrit.wikimedia.org/r/1002603

gerritbot added a comment.Feb 12 2024, 9:24 PM

Change 1002607 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.17] Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1

https://gerrit.wikimedia.org/r/1002607

Stashbot added a comment.Feb 12 2024, 9:25 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:25:07Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:1002607|Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1 (T357212)]]

Stashbot added a comment.Feb 12 2024, 9:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:26:27Z] <cjming@deploy2002> cjming and jdlrobson: Backport for [[gerrit:1002607|Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1 (T357212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2024, 9:31 PM
Stashbot added a comment.Feb 12 2024, 9:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:38:06Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:1002607|Use @wikimedia/mediawiki.skins.clientpreferences@1.1.1 (T357212)]] (duration: 12m 58s)

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Feb 12 2024, 9:51 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3) board.
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.17; 2024-02-06); removed MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 12 2024, 10:00 PM
Edtadros removed Edtadros as the assignee of this task.Feb 13 2024, 10:00 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3) board.
Edtadros subscribed.

Note: This has already been tested in Prod and passes. This is just docomenting the Beta validation.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Open https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileOptions
Toggle "Advanced mode"
The page reloads
✅ AC1: The option gets toggled.

screenshot 245.mov.gif (954×448 px, 226 KB)

Edtadros added a project: Verified.Feb 13 2024, 10:01 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Open https://en.m.wikipedia.org/wiki/Special:MobileOptions
Toggle "Advanced mode"
The page reloads
✅ AC1: The option gets toggled.

screenshot 244.mov.gif (954×448 px, 284 KB)

Edtadros updated the task description. (Show Details)Feb 13 2024, 10:03 PM
Edtadros mentioned this in T356137: Verify 1.42.0-wmf.17 deployment.Feb 14 2024, 10:54 PM
Jdlrobson assigned this task to ovasileva.Feb 15 2024, 5:35 PM
ovasileva closed this task as Resolved.Feb 16 2024, 12:13 PM

Looks good, resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits