Page MenuHomePhabricator

Wikitext-related toolbar buttons are visible even when CodeEditor is on
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:
The toolbar buttons in the format and insert groups (Bold, Italic, Link, Image...) appear on the WikiEditor toolbar.

image.png (162×582 px, 10 KB)

And when you turn CodeEditor off, its buttons (Indent, Outdent...) are still visible.

What should have happened instead?:
The format and insert buttons are not visible while <> is pressed. And while it is not, CodeEditor's buttons are invisible.

QA Results - Beta & Prod

Event Timeline

Change 1000872 had a related patch set uploaded (by Nardog; author: Nardog):

[mediawiki/extensions/CodeEditor@master] Update toolbar group hiding logic

https://gerrit.wikimedia.org/r/1000872

Change 1001296 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CodeEditor@master] Hide 'insert' and 'format' toolbar groups

https://gerrit.wikimedia.org/r/1001296

Change 1001296 abandoned by Samwilson:

[mediawiki/extensions/CodeEditor@master] Hide 'insert' and 'format' toolbar groups

Reason:

In favour of I10e06d129677e7ac40199a31e4bad7914dda993c

https://gerrit.wikimedia.org/r/1001296

Change 1000872 merged by jenkins-bot:

[mediawiki/extensions/CodeEditor@master] Update toolbar group hiding logic

https://gerrit.wikimedia.org/r/1000872

Nardog renamed this task from Format and insert toolbar buttons are visible even when CodeEditor is on to Wikitext-related toolbar buttons are visible even when CodeEditor is on.Feb 11 2024, 3:41 AM

@Nardog The only difference is that Beta is showing the insert a template icon compared to Prod not having it. Not sure if you wanted that included or not. Otherwise, the format and insert buttons are not visible while "<>" is pressed as seen in the screenshots. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (1cc8210)
OS: macOS Sonoma 14.2.1
Browser: Chrome 121, Firefox 123, Safari 17.3, Edge 121
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&action=edit
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Common.css&action=edit

✅AC1: https://phabricator.wikimedia.org/T357222

On/OffProdBeta
CodeEditor On
2024-02-15_14-10-31.png (1×2 px, 294 KB)
2024-02-15_14-12-52.png (1×1 px, 314 KB)
CodeEditor Off
2024-02-15_14-10-19.png (1×2 px, 291 KB)
2024-02-15_14-13-06.png (1×2 px, 312 KB)

It appears the template insertion button doesn't get added for those who can't edit the page.

That makes sense, thanks for the update!