Page MenuHomePhabricator
Create Task
Maniphest T357486

Expand all sections should show on resize
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
• Mabualruz
Authored By
Jdlrobson
Feb 13 2024, 11:55 PM
Project Tags
Referenced Files
F44418264: screenshot 18.mov.gif
Apr 4 2024, 2:52 AM
F43463606: screenshot 12.mov.gif
Mar 26 2024, 9:15 PM
F42880038: screenshot 11.mov.gif
Mar 20 2024, 9:34 PM
F42638003: Screencast from 15-03-24 12:40:21 PM IST.webm
Mar 15 2024, 7:12 AM
F42633213: image.png
Mar 15 2024, 2:14 AM
F42633197: image.png
Mar 15 2024, 2:14 AM
F42632890: image.png
Mar 15 2024, 1:53 AM
F42609703: image.png
Mar 14 2024, 2:00 AM
Subscribers
Aklapper
Edtadros
Jdlrobson
Rockingpenny4

Description

Discovered by @Edtadros in T350170#9530953

Steps to replicate the issue (include links if applicable):

What happens?:
Nothing.

What should have happened instead?:

The expand all sections setting should display.
(It shows if you refresh the page)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The logic in https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/src/mobile.special.mobileoptions.scripts.js#L168 should be revised. I would suggest unconditionally adding it and that adding CSS to hide/show #skin-client-prefs-mf-expand-sections

QA Results - Beta

ACStatusDetails
1✅T357486#9663644

QA Results - Prod

ACStatusDetails
1✅T357486#9686750

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fixes expand section visibility on browser resizeRockingpenny4mediawiki/extensions/MobileFrontendmaster+16 -20
Fixes expand sections visibility on browser resizeRockingpenny4mediawiki/extensions/MobileFrontendmaster+22 -22
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 13 2024, 11:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2024, 11:55 PM
Jdlrobson updated the task description. (Show Details)Feb 13 2024, 11:56 PM
Jdlrobson added a subscriber: Edtadros.
ovasileva triaged this task as Medium priority.Feb 15 2024, 12:12 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5); removed: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4).Feb 26 2024, 7:04 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived; removed: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5).Mar 11 2024, 7:08 PM
Jdlrobson added a project: Readers Essential Work.Mar 12 2024, 5:52 PM
Jdlrobson moved this task from For triage to Q3 (Jan-April) on the Readers Essential Work board.Mar 13 2024, 12:53 AM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6); removed: Web-Team-Backlog-Archived.
Jdlrobson moved this task from Q3 (Jan-April) to Q4 (April-July) on the Readers Essential Work board.Mar 13 2024, 5:24 PM
Rockingpenny4 subscribed.Mar 14 2024, 2:00 AM

@Jdlrobson my Special:MobileOptions on mediawiki docker setup looks like this

image.png (1,842×846 px, 220 KB)
, I followed https://www.mediawiki.org/wiki/Extension:MobileFrontend/en. Can you assist me with this?

Jdlrobson added a comment.EditedMar 14 2024, 6:16 PM

@Rockingpenny4 I think you may need to run the following code from inside docker in the mediawiki core folder:

php maintenance/rebuildLocalisationCache.php --force

That should address the translation problems.
Then you should click the "mobile view" link in the bottom of the page!

Hope this is helpful!

Jdlrobson edited projects, added: Web-Team-Backlog-Archived; removed: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6), Readers Essential Work.Mar 14 2024, 6:18 PM
Rockingpenny4 added a comment.Mar 15 2024, 12:25 AM
This comment was removed by Rockingpenny4.
Rockingpenny4 added a comment.Mar 15 2024, 1:53 AM

@Jdlrobson thanks , that did the job , however I'm not seeing my local changes reflect on the browser for some reason , I followed this command as well

image.png (888×270 px, 34 KB)

Rockingpenny4 added a comment.Mar 15 2024, 2:14 AM

From my guess here , isWideScreen() is not updated on browser resize but rather on page reload

image.png (849×202 px, 41 KB)
, due to which showExpandSectionsClientPreference is not given the value of 'true' here{F42633213}. However, I am not entirely sure as I am not able to console.log any debug statements to the browser. Also from the description , by adding CSS do you mean using media queries for it?

Rockingpenny4 added a comment.Mar 15 2024, 2:14 AM

From my guess here , isWideScreen() is not updated on browser resize but rather on page reload

image.png (849×202 px, 41 KB)
, due to which showExpandSectionsClientPreference is not given the value of 'true' here
image.png (860×221 px, 19 KB)
. However, I am not entirely sure as I am not able to console.log any debug statements to the browser. Also from the description , by adding CSS do you mean using media queries for it?

Jdlrobson added a comment.Mar 15 2024, 4:39 AM

Hi just a quick note to say that you will need to run npm start to makes sure any changes you make compile the JavaScript. Hope this helps! I can give you more pointers tomorrow!

gerritbot added a comment.Mar 15 2024, 7:07 AM

Change 1011221 had a related patch set uploaded (by Rockingpenny4; author: Rockingpenny4):

[mediawiki/extensions/MobileFrontend@master] Fixes expand section visibility on browser resize

https://gerrit.wikimedia.org/r/1011221

gerritbot added a project: Patch-For-Review.Mar 15 2024, 7:07 AM
Rockingpenny4 added a comment.Mar 15 2024, 7:12 AM

@Jdlrobson Thanks that worked , I have made a patch for the fix. Here is the relevant screencast:

gerritbot added a comment.Mar 15 2024, 7:31 AM

Change 1010973 had a related patch set uploaded (by Rockingpenny4; author: Rockingpenny4):

[mediawiki/extensions/MobileFrontend@master] Fixes expand section visibility on browser resize

https://gerrit.wikimedia.org/r/1010973

gerritbot added a comment.Mar 15 2024, 7:31 AM

Change 1011221 abandoned by Rockingpenny4:

[mediawiki/extensions/MobileFrontend@master] Fixes expand section visibility on browser resize

Reason:

fails test

https://gerrit.wikimedia.org/r/1011221

gerritbot added a comment.Mar 15 2024, 6:30 PM

Change 1011221 restored by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Fixes expand section visibility on browser resize

https://gerrit.wikimedia.org/r/1011221

Jdlrobson added a comment.Mar 15 2024, 6:33 PM

Thanks for sharing the screencast! Your fix looks good! I left you a comment about how we could simplify this a little more!

Rockingpenny4 added a comment.Mar 18 2024, 4:09 AM

@Jdlrobson I have updated the patch according to the requested changes. Please review.

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5); removed: Web-Team-Backlog-Archived.Mar 18 2024, 5:51 PM

Thanks @Rockingpenny4 for the patch. It will be deployed this week as part of our deployments!

Moving to our sprint board so a QA engineer can test and verify the bug fix.

Jdlrobson assigned this task to Edtadros.Mar 18 2024, 5:51 PM
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.
Jdlrobson set the point value for this task to 0.
Rockingpenny4 added a comment.Mar 19 2024, 10:27 AM

Thanks a lot @Jdlrobson for your help , I will definitely keep the inputs in mind for future contributions.

Edtadros added a comment.Mar 20 2024, 4:28 PM

@Jdlrobson can you add the version tag to this please.

Edtadros removed Edtadros as the assignee of this task.Mar 20 2024, 9:34 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.org/wiki/Special:MobileOptions
Resize browser
Nothing.
❌ The expand all sections setting should display.
The setting only shows if the page is refreshed. It also only disappears if you refresh the page.

screenshot 11.mov.gif (1,198×1,038 px, 3 MB)

Jdlrobson assigned this task to Edtadros.EditedMar 20 2024, 9:36 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.
Jdlrobson added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).

@Edtadros looks like patch didn't go through. Trying again. Please test again in beta cluster when I give you the green light.

Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.Mar 20 2024, 9:37 PM
gerritbot added a comment.Mar 20 2024, 10:01 PM

Change 1011221 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fixes expand sections visibility on browser resize

https://gerrit.wikimedia.org/r/1011221

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.Mar 20 2024, 10:24 PM
ovasileva edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6); removed: Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5).Mar 26 2024, 8:06 AM
ovasileva moved this task from Incoming to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6) board.Mar 26 2024, 8:19 AM
Edtadros removed Edtadros as the assignee of this task.Mar 26 2024, 9:15 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.org/wiki/Special:MobileOptions or beta equivalent
Resize browser
✅ AC1: The expand all sections setting should display.

screenshot 12.mov.gif (980×768 px, 999 KB)

Edtadros updated the task description. (Show Details)Mar 26 2024, 9:16 PM
Jdrewniak assigned this task to • Mabualruz.Mar 28 2024, 4:38 PM
• Mabualruz closed this task as Resolved.Mar 29 2024, 7:41 AM

Great work, it looks and works as intended

Edtadros added a project: Verified.Apr 4 2024, 2:52 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.org/wiki/Special:MobileOptions or beta equivalent
Resize browser
✅ AC1: The expand all sections setting should display.

screenshot 18.mov.gif (864×966 px, 1 MB)

Edtadros updated the task description. (Show Details)Apr 4 2024, 2:52 AM
Edtadros mentioned this in T360464: Verify 1.42.0-wmf.24 deployment.Apr 4 2024, 2:55 AM
gerritbot added a comment.Apr 28 2024, 8:30 PM

Change #1010973 abandoned by Rockingpenny4:

[mediawiki/extensions/MobileFrontend@master] Fixes expand section visibility on browser resize

Reason:

duplicate patch for I0212083fca450a12339ec7105eb61b4edce6f3de

https://gerrit.wikimedia.org/r/1010973

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits