Page MenuHomePhabricator

Temporary account IP reveal fails for log entries that are for the creation of a page
Closed, ResolvedPublicBUG REPORT

Description

The CheckUser extension does not store the IP address associated with the log event for a page creation. This is because the log entry is deliberately never published to Special:RecentChanges as shown in PageUpdater::doCreate.

This means that no IP address data is logged for this log event and as such when a user with the ability to reveal temporary account IPs tries to reveal the IP for this log action there will be no data. Instead the data will be associated with the revision ID that created the page and instead this should be used for this log action type.

Found by @GMikesell-WMF as part of QA on T355434.

Steps to replicate the issue
  1. Enable temporary account autocreation
  2. Create a new page using a temporary account
  3. Log into an account with the checkuser group
  4. Go to Special:Log
  5. Click on Show IP next to the temporary account username on the log event for the creation of the page

What happens?:
The data is unavailable and no IP address is displayed

What should have happened instead?:
The IP address used to make the first revision of the page should be displayed.

Software version

MediaWiki 1.42.0-alpha (570bd68) 13:28, 6 February 2024. CheckUser 2.5 (9fafdf8) 11:03, 13 February 2024

Event Timeline

Dreamy_Jazz renamed this task from No IP data available for the log entry for the creation of a page to No IP data available for log entries that are for the creation of a page.Feb 14 2024, 12:23 PM
Dreamy_Jazz renamed this task from No IP data available for log entries that are for the creation of a page to Temporary account IP reveal fails for log entries that are for the creation of a page.
Dreamy_Jazz updated the task description. (Show Details)

I am unable to reproduce this issue. Was this already fixed?

Software version: MediaWiki: 1.43.0-alpha (3804015), CheckUser 2.5 (22076b9)

kostajh subscribed.

I am unable to reproduce this issue. Was this already fixed?

Software version: MediaWiki: 1.43.0-alpha (3804015), CheckUser 2.5 (22076b9)

Possibly! Moving to QA.

This was half-fixed by disabling the Show IP button in T370083. As such, the steps to reproduce don't work now but if the button is re-enabled then it would fail in the same way.

Djackson-ctr subscribed.

Since the Show IP button has been removed from Special:Logs, I have verified that is still the case with this ticket, so pushing this to Done.

image.png (1,119×69 px, 16 KB)

Dreamy_Jazz claimed this task.

Re-opening this so that we can implement a proper fix (which is to display an IP address).

Change #1111286 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Find IP address for page creation log in temp IP reveal

https://gerrit.wikimedia.org/r/1111286

Change #1111286 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Support temp user IP reveal for page creation logs

https://gerrit.wikimedia.org/r/1111286

QA is completed... new code changes have been implemented (after selecting Show IP, the IP address will be displayed).