Page MenuHomePhabricator

Flow doesn't work in night mode
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The content is unreadable

Screenshot 2024-02-14 at 5.51.48 PM.png (1×2 px, 302 KB)

What should have happened instead?:
Another reason to sunset Flow?
(I am not sure how we could disable night mode on Flow only pages - currently our configuration only supports namespaces so we'd need to disable every single Flow page - assuming there's a small amount of them?)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Problematic rules include `.flow-post { color: #202122; }

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

The following styles (if scoped to the correct HTML elements) might help here if we need a short term fix:

[data-flow-component="board"] * {
    background: transparent !important;
    background-color: transparent !important;
}

.oo-ui-iconElement-icon:not( .oo-ui-image-progressive ),
[data-flow-component="board"]  .mw-ui-icon:before {
    filter: invert(1);
}

.flow-board-header::before {
    content: none !important;
}

.oo-ui-messageWidget.oo-ui-messageWidget-block.oo-ui-flaggedElement-notice {
    background-color: black;
}

.oo-ui-buttonElement-frameless.oo-ui-widget-enabled > .oo-ui-buttonElement-button {
    color: var(--color-base)
}

.ve-ui-targetWidget:not(.oo-ui-pendingElement-pending) {
    background: #000;
}

.oo-ui-textInputWidget .oo-ui-inputWidget-input {
    background-color: #000;
    color: #fff;
}

Change #1050488 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Flow@master] Make Flow work in dark mode by disabling backgrounds and setting text

https://gerrit.wikimedia.org/r/1050488

Change #1050488 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Make Flow work in dark mode by disabling backgrounds and setting text

https://gerrit.wikimedia.org/r/1050488

Change #1051396 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Flow@wmf/1.43.0-wmf.11] Make Flow work in dark mode by disabling backgrounds and setting text

https://gerrit.wikimedia.org/r/1051396

Unfortunately, it fails in a bit more complex cases: I’ve highlighted blocks with barely readable texts with red borders; also, links are black rather than blue, making them not recognizable as links.

Screenshot 2024-07-14 at 11-28-39 Manual talk FAQ – MediaWiki.png (623×355 px, 53 KB)

Change #1051396 abandoned by Umherirrender:

[mediawiki/extensions/Flow@wmf/1.43.0-wmf.11] Make Flow work in dark mode by disabling backgrounds and setting text

https://gerrit.wikimedia.org/r/1051396

Jdlrobson reopened this task as Open.EditedJul 15 2024, 6:22 PM

The main goal here was to get the basics out of the way (e.g. make content readable). Given Flow's maintenance status and unclear future I don't think it makes sense to do more work on this extension for dark mode. I'm reopening to make it clearer that this is not fully fixed.

Jdlrobson added a subscriber: ovasileva.
Jdlrobson added a subscriber: ppelberg.

@ppelberg what is the long term plan for Flow? I assume it is going to be replaced with discussion tools at some point. Is there a timeline or any plans in motion?

@ppelberg what is the long term plan for Flow? I assume it is going to be replaced with discussion tools at some point. Is there a timeline or any plans in motion?

@Jdlrobson see T332022: [Epic] Undeploying StructuredDiscussions (Flow)

Might make sense to set task status to declined.

ppelberg added a subscriber: Trizek-WMF.

@ppelberg what is the long term plan for Flow? I assume it is going to be replaced with discussion tools at some point. Is there a timeline or any plans in motion?

Thank you for chiming in, @kostajh.

In case some additional details would be helpful, @Trizek-WMF are working on a un-deployment timeline/sequence here: T370722.

As the goal is to sunset this extension, I don't find it relevant to make lots of efforts to adapt Flow to night mode. :) I would decline it officially, saying we won't adapt it at all.

I don't think this should be declined - if some volunteer thinks differently than you and writes a patch to do this it will probably get reviewed and merged.

Yeah, I just want to flag that it could be a lot of effort for a quite short appearance on wikis.

From my experience it's really difficult to find someone willing to merge patches to Flow so I wouldn't want a volunteer to spend time on this for nothing.