Maniphest T357672

🍦 Handle invalid requests where sitelink title is not a string
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Feb 15 2024, 2:32 PM

Tags

Referenced Files

None

Subscribers

Description

E.g. for request body { "sitelink": { "title": [] } } it should respond with a 400 invalid-title-field.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Handle invalid type of sitelink title	mediawiki/extensions/Wikibase	master	+38 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ifrahkhanyaree_WMDE	T344228 Functionality for REST API v1
		Resolved		Ifrahkhanyaree_WMDE	T342987 🍦 Create/replace a sitelink to an item on a given wiki
		Resolved		Silvan_WMDE	T357672 🍦 Handle invalid requests where sitelink title is not a string

Event Timeline

Jakob_WMDE created this task.Feb 15 2024, 2:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2024, 2:32 PM

Jakob_WMDE updated the task description. (Show Details)Feb 16 2024, 9:44 AM

Silvan_WMDE claimed this task.Feb 16 2024, 3:17 PM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 13) board.

Change 1004188 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Handle invalid type of sitelink title

https://gerrit.wikimedia.org/r/1004188

gerritbot added a project: Patch-For-Review.Feb 16 2024, 4:22 PM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 13) board.Feb 16 2024, 5:10 PM

Change 1004188 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle invalid type of sitelink title

https://gerrit.wikimedia.org/r/1004188

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2024, 3:30 PM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 13) board.Feb 19 2024, 5:31 PM

Ifrahkhanyaree_WMDE moved this task from Sprint 13 to Sprint 14 on the Wikibase Reuse Team board.Feb 20 2024, 1:28 PM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Reuse Team (Sprint 14); removed Wikibase Reuse Team (Sprint 13).

Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 14) board.Feb 20 2024, 1:31 PM

Silvan_WMDE moved this task from Doing to Done on the Wikibase Reuse Team (Sprint 14) board.Feb 20 2024, 1:38 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 1:00 AM

Ifrahkhanyaree_WMDE closed this task as Resolved.Mar 5 2024, 11:17 AM