Page MenuHomePhabricator

Color contrast issue with Template:Side_box in Minerva Night Mode
Closed, ResolvedPublic

Description

Context:
Per the most recent color contrast checker run, there are about 72 color contrast violations in the top 100 wikipedia pages related to .sidebox elements.

Issue Details:
Skin: Minerva (Night Mode)
Problem Area: Template:Side_box

Steps to Reproduce:
Go to a sample page
Navigate to any .sidebox element

Expected Result:
The text and background colors within the infobox should have a WCAG 2.0 level AA contrast ratio of at least 4.5:1 for normal text and 3:1 for large text.

Actual Result

Foreground color (hex)Background color (hex)SizeContrastAAAAA
#EAECFO#F9F9F9Small1.12XX
Foreground color (hex)Background color (hex)SizeContrastAAAAA
#6699FF#F9F9F9Small2.64xx

Screenshot 2024-02-15 at 3.23.48 PM.png (1×1 px, 1 MB)

Suggested fix

Proposed solution is add the following rule to Minerva's template hacks file (scoped to only apply in night mode):

.side-box, .side-box * { background: inherit !important; color: inherit !important;  }

Note: Jon to give the complete selector - many projects use localized versions of .side-box class.

QA Results - Beta

ACStatusDetails
1T357726#9612779

QA Results - Prod

ACStatusDetails
1T357726#9616722

Related Objects

StatusSubtypeAssignedTask
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
ResolvedJdlrobson
Resolvedovasileva
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedNone
DeclinedJdlrobson
ResolvedSToyofuku-WMF
ResolvedJdlrobson
ResolvedKSarabia-WMF

Event Timeline

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a sample page on prod. On Beta go to https://en.m.wikipedia.beta.wmflabs.org/wiki/India
Navigate to any .sidebox element

✅ AC1: The text and background colors within the infobox should have a WCAG 2.0 level AA contrast ratio of at least 4.5:1 for normal text and 3:1 for large text.

screenshot 694.png (1×1 px, 443 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a sample page on prod. On Beta go to https://en.m.wikipedia.beta.wmflabs.org/wiki/India
Navigate to any .sidebox element

✅ AC1: The text and background colors within the infobox should have a WCAG 2.0 level AA contrast ratio of at least 4.5:1 for normal text and 3:1 for large text.

screenshot 695.png (1×1 px, 700 KB)