Page MenuHomePhabricator
Create Task
Maniphest T357796

Inconsistent \ and \\ in namespaced classes in TestsAutoLoader.php
Closed, ResolvedPublic
Actions

Description

We have both \ and \\ being used in TestsAutoLoader.php; we should at least be consistent

'MediaWiki\Tests\Maintenance\DumpAsserter' => "$testDir/phpunit/maintenance/DumpAsserter.php",
'MediaWiki\\Tests\\BrokenClass' => "$testDir/phpunit/mocks/BrokenClass.php",

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
TestsAutoLoader: Consistently use \\Reedymediawiki/coremaster+45 -41
Customize query in gerrit

Event Timeline

Reedy created this task.Feb 16 2024, 5:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2024, 5:08 PM
gerritbot added a comment.Feb 16 2024, 5:11 PM

Change 1004203 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] TestsAutoLoader: Consistently use \\

https://gerrit.wikimedia.org/r/1004203

gerritbot added a project: Patch-For-Review.Feb 16 2024, 5:11 PM
Reedy triaged this task as Low priority.Feb 16 2024, 5:11 PM
gerritbot added a comment.Feb 16 2024, 11:08 PM

Change 1004203 merged by jenkins-bot:

[mediawiki/core@master] TestsAutoLoader: Consistently use \\

https://gerrit.wikimedia.org/r/1004203

Reedy closed this task as Resolved.Feb 16 2024, 11:18 PM
Reedy claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Feb 16 2024, 11:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 17 2024, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits